Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double login with one login source #329

Closed
eljeffeg opened this issue Feb 27, 2025 · 3 comments
Closed

Double login with one login source #329

eljeffeg opened this issue Feb 27, 2025 · 3 comments
Assignees
Labels
accepted This issue was accepted, we will work on this at some point bug Something isn't working pending review ui-frontend

Comments

@eljeffeg
Copy link

eljeffeg commented Feb 27, 2025

Describe the bug
When only one login source is configured, the UI is suppose to skip the second auth screen. However, this doesn't appear to be working with SAML.

Ryan pointed out Maybe there's no tokenID being set for SAML auth vs OAuth? as the potential bug.

Might have to do with this line:
https://github.com/CybercentreCanada/assemblyline-ui-frontend/blob/master/src%2Fcomponents%2Froutes%2Flogin%2Fsso.tsx#L37

Discord Chat

@eljeffeg eljeffeg added assess We still haven't decided if this will be worked on or not bug Something isn't working labels Feb 27, 2025
@cccs-rs cccs-rs self-assigned this Feb 27, 2025
@cccs-rs
Copy link
Contributor

cccs-rs commented Feb 27, 2025

During local testing it looks like we do get a tokenID via SAML, but I think we're running into some kind of timing issue on the frontend.

The first few logs show that the tokenID is null but then eventually does come back with a value but this is after the second login shows up. Will investigate further.

@cccs-rs cccs-rs added ui-frontend accepted This issue was accepted, we will work on this at some point and removed assess We still haven't decided if this will be worked on or not labels Feb 27, 2025
@cccs-rs
Copy link
Contributor

cccs-rs commented Feb 27, 2025

Looks like timing wasn't an issue at all, just a bad condition to allow quick logins😅

cccs-rs added a commit to CybercentreCanada/assemblyline-ui-frontend that referenced this issue Mar 7, 2025
Perform a length check to assess if there's any OAuth providers confi… (dev)
cccs-nr added a commit to CybercentreCanada/assemblyline-ui-frontend that referenced this issue Mar 7, 2025
Perform a length check to assess if there's any OAuth providers configured alongside SAML
@cccs-rs
Copy link
Contributor

cccs-rs commented Mar 7, 2025

Should be resolved in this release.

@cccs-rs cccs-rs closed this as completed Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue was accepted, we will work on this at some point bug Something isn't working pending review ui-frontend
Projects
None yet
Development

No branches or pull requests

2 participants