Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionEndEP in plugin seems to not work during the Bidsmap creation step #16

Open
nkuegler opened this issue Dec 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nkuegler
Copy link

nkuegler commented Dec 5, 2024

During bidsification, I am checking if a specific parameter matches specific recordings across the session. Therefore, the parameter is written to a global variable and checked for each recording in RecordingEP. In SessionEndEP, the global variable is reset to its starting value which works fine during the bidsification, but does not happen during the Bidsmapping step, leading to a warning due to a mismatch.
Moving the same step to one of the beginning EPs avoided the warning, but doesn't fit my purpose. I did not test if the problem occurs only with SessionEndEP or also with other EndEP's.
Again, this problem only occurs during Bidsmap creation, not during the actual data bidsification.

@nbeliy nbeliy self-assigned this Dec 6, 2024
@nbeliy nbeliy added the bug Something isn't working label Dec 6, 2024
@nbeliy
Copy link
Collaborator

nbeliy commented Dec 6, 2024

Hi @nkuegler ,

Indeed, during mapping, there's no call for SessionEndEP (or SubjectEndEP). Not sure if it was just forgotten, or there was a reason. I'll fix it at next release.

For a quick fix, will it be possible for you to move the reset of global variable to SessionEP?

@nkuegler
Copy link
Author

nkuegler commented Dec 6, 2024

Hi Nikita,
Thanks for asking, but it is not a huge problem for me. I just wanted to make you aware of it, if this was a bug.

Best,
Niklas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants