Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not updated: geographic coordinates for societies in 'tdwg societies' file #280

Closed
kirbykat opened this issue Sep 4, 2020 · 8 comments
Closed
Assignees
Milestone

Comments

@kirbykat
Copy link
Collaborator

kirbykat commented Sep 4, 2020

It looks like lat/long coordinates for societies Koreans (Ed1) and Negri Sembilan (Ej16) in this file have not been updated/corrected, while those in the datasets > EA > societies.csv file HAVE. I'm believe (but am not sure - @xrotwang?) that the tdwg societies file is only used for display/mapping on the site. Can we pull the tdwg lat/lon from individual society.csv files?

Updated (columns "Lat" and "Long":
https://github.com/D-PLACE/dplace-data/blob/master/datasets/EA/societies.csv

Not updated:
https://github.com/D-PLACE/dplace-data/blob/master/geo/societies_tdwg.json

@xrotwang
Copy link
Collaborator

xrotwang commented Sep 7, 2020

societies_tdwg.json is only used to populate the region attribute - so the issue shouldn't have any effect on the app (or most analyses).
The file will be regenerated when dplace tdwg is run, i.e. when a new release is created.

@xrotwang
Copy link
Collaborator

xrotwang commented Sep 7, 2020

I'll leave the issue open until I run dplace tdwg (to confirm that I was correct above :) ).

@xrotwang xrotwang self-assigned this Sep 7, 2020
@kirbykat
Copy link
Collaborator Author

kirbykat commented Sep 8, 2020

@xrotwang that sounds good, but in that case should it have updated when 2.1 was released? The changes to the coordinates of Koreans (Ed1) and Negri Sembilan (Ej16) were made before the release of 2.1, I'm almost certain. Thanks!

@kirbykat
Copy link
Collaborator Author

kirbykat commented Sep 8, 2020

(My concern is for people who try to build a flat file for analysis, and decide to pull lat lon from the tdwg file instead of from the societies file. Obvs. not a big deal, but will start introducing errors/make things less reproducible.)

@SimonGreenhill
Copy link
Collaborator

yeah, we need to make a new release of DPLACE very soon

@xrotwang
Copy link
Collaborator

xrotwang commented Sep 8, 2020

@kirbykat yes, you are right, there's potential for confusion. I think I didn't re-run the region identification, because there were no new societies (between 2.0 and 2.1). @SimonGreenhill and I were thinking about some sort of CLDFy release format for D-PLACE data. This might help in making more transparent what we think should be used and how.

@SimonGreenhill SimonGreenhill added this to the D-PLACE 2 milestone Sep 9, 2020
@SimonGreenhill
Copy link
Collaborator

See also #321

@xrotwang
Copy link
Collaborator

Resolved with the new model of curating the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants