Skip to content

Commit 326475c

Browse files
authored
Merge pull request #5054 from myk002/myk_container_label
update the build env label
2 parents 33acc1f + 21ce133 commit 326475c

File tree

4 files changed

+7
-12
lines changed

4 files changed

+7
-12
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ endif()
5656

5757
if(WIN32)
5858
set(MSVC_MIN_VER 1930)
59-
set(MSVC_MAX_VER 1941)
59+
set(MSVC_MAX_VER 1942)
6060
if(NOT MSVC)
6161
message(SEND_ERROR "No MSVC found! MSVC 2022 version ${MSVC_MIN_VER} to ${MSVC_MAX_VER} is required.")
6262
elseif((MSVC_VERSION LESS MSVC_MIN_VER) OR (MSVC_VERSION GREATER MSVC_MAX_VER))

build/build-win64-from-linux.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ if [[ $(id -u) -eq 0 ]]; then
3232
chown -R $builder_uid win64-cross
3333
fi
3434

35-
# Assumes you built a container image called dfhack-build-msvc from
36-
# https://github.com/BenLubar/build-env/tree/master/msvc, see
37-
# docs/dev/compile/Compile.rst.
35+
# Pulls the MSVC build env container from the GitHub registry
3836
#
3937
# NOTE: win64-cross is mounted in /src/build due to the hardcoded `cmake ..` in
4038
# the Dockerfile
@@ -44,7 +42,7 @@ if ! docker run --rm -i -v "$srcdir":/src -v "$srcdir/build/win64-cross/":/src/b
4442
-e steam_username \
4543
-e steam_password \
4644
--name dfhack-win \
47-
ghcr.io/dfhack/build-env:msvc \
45+
ghcr.io/dfhack/build-env:master \
4846
bash -c "cd /src/build && dfhack-configure windows 64 Release -DCMAKE_INSTALL_PREFIX=/src/build/output -DBUILD_DOCS=1 $CMAKE_EXTRA_ARGS && dfhack-make -j$jobs install" \
4947
; then
5048
echo

docs/changelog.txt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ Template for new versions:
5252
# Future
5353

5454
## New Tools
55-
- `infinite-sky`: (reinstated, renamed from ``infiniteSky``) tool for automatically creating new z-levels of sky to build in
56-
- `forceequip`: (reinstated) Forcibly move items into a unit's inventory
55+
- `infinite-sky`: (reinstated, renamed from ``infiniteSky``) automatically create new z-levels of sky to build in
56+
- `forceequip`: (reinstated) forcibly move items into a unit's inventory
5757

5858
## New Features
5959
- `tweak`: ``realistic-melting``: change melting return for inorganic armor parts, shields, weapons, trap components and tools to stop smelters from creating metal, bring melt return for adamantine in line with other metals to ~95% of forging cost. wear reduces melt return by 10% per level
@@ -63,11 +63,10 @@ Template for new versions:
6363
- `autobutcher`: don't run a scanning and marking cycle on the first tick of a fortress to allow for all custom configuration to be set first
6464
- `nestboxes`: don't consider eggs to be infertile just because the mother has left the nest; eggs can still hatch in this situation
6565
- `timestream`: adjust the incubation counter on fertile eggs so they hatch at the expected time
66-
- `timestream`: fix potential crash in birthday tracking
6766
- `logistics`: don't ignore rotten items when applying stockpile logistics operations (e.g. autodump, autoclaim, etc.)
6867

6968
## Misc Improvements
70-
- DFHack startup now verifies that its idea of the size of certain DF global objects are the same as what DF says they are, and refuses to start if there is a mismatch
69+
- DFHack now verifies that critical DF data structures have known sizes and refuses to start if there is a mismatch
7170
- DFHack text edit fields now delete the character at the cursor when you hit the Delete key
7271
- DFHack text edit fields now move the cursor by one word left or right with Ctrl-Left and Ctrl-Right
7372
- DFHack text edit fields now move the cursor to the beginning or end of the line with Home and End
@@ -82,12 +81,10 @@ Template for new versions:
8281
- The error message that comes up if there is a version mismatch between DF and the installed DFHack now informs you which DF versions are supported by the installed version of DFHack
8382

8483
## API
85-
8684
- ``DFHack::Units``: new function ``setPathGoal``
8785
- ``Units::setAutomaticProfessions``: bay12-provided entry point to assign labors based on work details
8886

8987
## Lua
90-
9188
- ``dfhack.units``: new function ``setPathGoal``
9289
- ``widgets.TabBar``: updated to allow for horizontal scrolling of tabs when there are too many to fit in the available space
9390

docs/dev/compile/Compile.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ Step 1: prepare a build container
303303
On your Linux host, install and run the docker daemon and then run these commands::
304304

305305
xhost +local:root
306-
docker run -it --env="DISPLAY" --env="QT_X11_NO_MITSHM=1" --volume=/tmp/.X11-unix:/tmp/.X11-unix --user buildmaster --name dfhack-win ghcr.io/dfhack/build-env:msvc
306+
docker run -it --env="DISPLAY" --env="QT_X11_NO_MITSHM=1" --volume=/tmp/.X11-unix:/tmp/.X11-unix --user buildmaster --name dfhack-win ghcr.io/dfhack/build-env:master
307307

308308
The ``xhost`` command and ``--env`` parameters are there so you can eventually
309309
run Dwarf Fortress from the container and have it display on your host.

0 commit comments

Comments
 (0)