don't check validity of item while deleting it

DFHack · Jan 13, 2024 · 60dcdbd · 60dcdbd
1 parent 3e74de5
commit 60dcdbd
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/library/modules/Persistence.cpp b/library/modules/Persistence.cpp
@@ -322,11 +322,13 @@ bool Persistence::deleteItem(const PersistentDataItem &item) {
 
     CoreSuspender suspend;
 
-    auto range = store[item.entity_id()].equal_range(item.key());
+    int entity_id = item.entity_id();
+
+    auto range = store[entity_id].equal_range(item.key());
     for (auto it = range.first; it != range.second; ++it) {
         if (it->second->isReferencedBy(item)) {
             entry_cache.erase(it->second->entry_id);
-            store[item.entity_id()].erase(it);
+            store[entity_id].erase(it);
             break;
         }
     }