From d2d3472b77315c8c728e75546a767bc1d0e69d6c Mon Sep 17 00:00:00 2001
From: Ethan Shen <42264778+nczitzk@users.noreply.github.com>
Date: Thu, 6 Feb 2025 00:09:02 +0800
Subject: [PATCH] fix(gcores): correct templates for images and videos (#18286)

---
 lib/routes/gcores/templates/description.art | 45 ++++++++++++++-------
 1 file changed, 30 insertions(+), 15 deletions(-)

diff --git a/lib/routes/gcores/templates/description.art b/lib/routes/gcores/templates/description.art
index bc3dbd13bdfa76..1ee123a8f1d2ce 100644
--- a/lib/routes/gcores/templates/description.art
+++ b/lib/routes/gcores/templates/description.art
@@ -1,12 +1,19 @@
 {{ if images }}
   {{ each images image }}
     {{ if image?.src }}
-      <img
-        {{ if image.alt }}
-          alt="{{ image.alt }}"
-        {{ /if }}
-        src="{{ image.src }}"
-      >
+      <figure>
+        <img
+          {{ if image.alt }}
+            alt="{{ image.alt }}"
+          {{ /if }}
+          {{ if image.width }}
+            width="{{ image.width }}"
+          {{ /if }}
+          {{ if image.height }}
+            height="{{ image.height }}"
+          {{ /if }}
+        src="{{ image.src }}">
+      </figure>
     {{ /if }}
   {{ /each }}
 {{ /if }}
@@ -27,18 +34,26 @@
   {{ /each }}
 {{ /if }}
 
-{{ if video }}
+{{ if videos }}
   {{ each videos video }}
     {{ if video?.src }}
-      <video
-        controls>
-        <source
+      {{ if video?.type?.endsWith('taptap') }}
+        <iframe
           src="{{ video.src }}"
-          type="{{ video.type }}">
-        <object data="{{ video.src }}">
-          <embed src="{{ video.src }}">
-        </object>
-      </video>
+          frameborder="0"
+          allowfullscreen>
+        </iframe>
+      {{ else }}
+        <video
+          controls>
+          <source
+            src="{{ video.src }}"
+            type="{{ video.type }}">
+          <object data="{{ video.src }}">
+            <embed src="{{ video.src }}">
+          </object>
+        </video>
+      {{ /if }}
     {{ /if }}
   {{ /each }}
 {{ /if }}