feat: replace fetching with reactqueries for block height fetching #56
Conversation
✅ Deploy Preview for resilient-salamander-989e97 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for singular-biscuit-78f561 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -25,6 +25,7 @@ export function MintUnmint({ address }: MintUnmintContainerProps): React.JSX.Ele | |||
| setTimeout(() => { | |||
| setAnimate(false); | |||
| }, 1000); | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
There was a problem hiding this comment.
not my fave, but we have a very strict linter, so it's okay. :)
| const { blockHeight } = useContext(BlockchainHeightContext); | ||
|
|
||
| let txID; | ||
| switch (vault?.state) { |
| @@ -35,7 +35,9 @@ export function useVaults(): UseVaultsReturnType { | |||
| }; | |||
|
|
|||
| useEffect(() => { | |||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | |||
There was a problem hiding this comment.
i don't know but if these lint rules are something you think we don't need or too restrictive, we can exclude some rules from the linter file instead of adding these comments.
There was a problem hiding this comment.
Generally, I like having the lint rules restrictive like this, we are only disabling lines which would warn us, not errors.
All of them are good rules, it's nice to have these kinds of warnings, but exhaustive deps can be too demanding is certain cases and no floating promises can be misleading (for example it doesn't see if we are awaiting a fetch function later in a Promise.all).
No description provided.