Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit to uuid, add Buffer to app #59

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

sosaucily
Copy link
Contributor

@sosaucily sosaucily commented Mar 25, 2024

This PR updates the PSBT generation code so that the user (Alice) must commit her deposit to a specific UUID from the smart contract, and prove that commitment when she uploads her PSBT.

This prevents clients from reusing the same deposit for multiple smart contracts on the ETH-side, because only a single UUID can be committed to per deposit.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for singular-biscuit-78f561 ready!

Name Link
🔨 Latest commit d5975e1
🔍 Latest deploy log https://app.netlify.com/sites/singular-biscuit-78f561/deploys/660187ef0f053900088b0253
😎 Deploy Preview https://deploy-preview-59--singular-biscuit-78f561.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for resilient-salamander-989e97 ready!

Name Link
🔨 Latest commit d5975e1
🔍 Latest deploy log https://app.netlify.com/sites/resilient-salamander-989e97/deploys/660187efa810940008e5a58f
😎 Deploy Preview https://deploy-preview-59--resilient-salamander-989e97.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sosaucily sosaucily force-pushed the support-buffer-and-commit-to-uuid branch 2 times, most recently from 071f35c to 4a533e5 Compare March 25, 2024 14:17
Copy link
Collaborator

@Polybius93 Polybius93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sosaucily sosaucily force-pushed the support-buffer-and-commit-to-uuid branch from 4a533e5 to d5975e1 Compare March 25, 2024 14:19
@sosaucily sosaucily merged commit 6c8d0f3 into dev Mar 25, 2024
16 checks passed
@sosaucily sosaucily deleted the support-buffer-and-commit-to-uuid branch March 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants