Fix quoting command result inside test (#141)

meisterT · DOMjudge team · web-flow · commit dfd3d91d9945 · 2024-05-06T21:58:40.000+02:00
Co-authored-by: DOMjudge team &lt;team@domjudge.org&gt;
diff --git a/provision-contest/ansible/roles/mysql_replication/templates/setup-replication.sh.j2 b/provision-contest/ansible/roles/mysql_replication/templates/setup-replication.sh.j2
@@ -126,9 +126,9 @@ get_field()
 check_status()
 {
     local sql_info="$(printf '%s\n' "$@")"
-    [ $(get_field 'Seconds_Behind_Master' "$sql_info") = '0' ] || return 1
-    [ $(get_field 'Slave_SQL_Running' "$sql_info") = 'Yes' ] || return 1
-    [ $(get_field 'Last_SQL_Errno' "$sql_info") = '0' ] || return 1
+    [ "$(get_field 'Seconds_Behind_Master' "$sql_info")" = '0' ] || return 1
+    [ "$(get_field 'Slave_SQL_Running' "$sql_info")" = 'Yes' ] || return 1
+    [ "$(get_field 'Last_SQL_Errno' "$sql_info")" = '0' ] || return 1
     return 0
 }
 

Original file line number	Diff line number	Diff line change
`@@ -126,9 +126,9 @@ get_field()`
`126`	`126`	`check_status()`
`127`	`127`	`{`
`128`	`128`	`local sql_info="$(printf '%s\n' "$@")"`
`129`		`- [ $(get_field 'Seconds_Behind_Master' "$sql_info") = '0' ] \|\| return 1`
`130`		`- [ $(get_field 'Slave_SQL_Running' "$sql_info") = 'Yes' ] \|\| return 1`
`131`		`- [ $(get_field 'Last_SQL_Errno' "$sql_info") = '0' ] \|\| return 1`
	`129`	`+ [ "$(get_field 'Seconds_Behind_Master' "$sql_info")" = '0' ] \|\| return 1`
	`130`	`+ [ "$(get_field 'Slave_SQL_Running' "$sql_info")" = 'Yes' ] \|\| return 1`
	`131`	`+ [ "$(get_field 'Last_SQL_Errno' "$sql_info")" = '0' ] \|\| return 1`
`132`	`132`	`return 0`
`133`	`133`	`}`
`134`	`134`