-
Notifications
You must be signed in to change notification settings - Fork 12
Add misc-tools to path #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Shouldn't this be filed against the main repository? But I'd also argue that we shouldn't try to tweak the user's path. Instead we should then copy those programs to the relevant bin dirs at installation time, which already happens: https://github.com/DOMjudge/domjudge/blob/main/misc-tools/Makefile#L28-L42 |
It doesn't happen for in place installs though (which I know is what Bartjan is using). |
Well, these scripts are linked from the domserver/judgehost bindir, see the Makefile link. So the simplest fix is to add that bindir to your path. |
So maybe we should do that in the Ansible? |
You mean the ansible code under https://github.com/DOMjudge/domjudge-scripts/tree/main/provision-contest/ansible? Sure, that's already setting up a complete machine including user. We shouldn't touch an existing user's PATH on an existing machine though. |
Yes that one :) . |
Certain tools (like import-contest) are convenient to have in the path
The text was updated successfully, but these errors were encountered: