Skip to content

Add misc-tools to path #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BHenkemans opened this issue May 7, 2025 · 6 comments
Open

Add misc-tools to path #183

BHenkemans opened this issue May 7, 2025 · 6 comments

Comments

@BHenkemans
Copy link
Contributor

BHenkemans commented May 7, 2025

Certain tools (like import-contest) are convenient to have in the path

@eldering
Copy link
Member

eldering commented May 7, 2025

Shouldn't this be filed against the main repository?

But I'd also argue that we shouldn't try to tweak the user's path. Instead we should then copy those programs to the relevant bin dirs at installation time, which already happens: https://github.com/DOMjudge/domjudge/blob/main/misc-tools/Makefile#L28-L42

@nickygerritsen
Copy link
Member

It doesn't happen for in place installs though (which I know is what Bartjan is using).

@eldering
Copy link
Member

eldering commented May 8, 2025

It doesn't happen for in place installs though (which I know is what Bartjan is using).

Well, these scripts are linked from the domserver/judgehost bindir, see the Makefile link. So the simplest fix is to add that bindir to your path.

@nickygerritsen
Copy link
Member

It doesn't happen for in place installs though (which I know is what Bartjan is using).

Well, these scripts are linked from the domserver/judgehost bindir, see the Makefile link. So the simplest fix is to add that bindir to your path.

So maybe we should do that in the Ansible?

@eldering
Copy link
Member

eldering commented May 8, 2025

So maybe we should do that in the Ansible?

You mean the ansible code under https://github.com/DOMjudge/domjudge-scripts/tree/main/provision-contest/ansible? Sure, that's already setting up a complete machine including user. We shouldn't touch an existing user's PATH on an existing machine though.

@nickygerritsen
Copy link
Member

So maybe we should do that in the Ansible?

You mean the ansible code under main/provision-contest/ansible? Sure, that's already setting up a complete machine including user. We shouldn't touch an existing user's PATH on an existing machine though.

Yes that one :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants