Lagswitch 845 (#847)

* Makes #845 a lag switch

* fuck

* Overwrite the previous AutoChangelog

Author: francinum

code/__DEFINES/lag_switch.dm

@@ -16,5 +16,7 @@
 #define DISABLE_PARALLAX 7
 /// Disables footsteps, TRAIT_BYPASS_MEASURES exempted
 #define DISABLE_FOOTSTEPS 8
+/// Disable icon VV render preview. Unlikely to be of use in 90% of circumstances, unless GFI starts shitting bricks again.
+#define DISABLE_VV_ICON_PREVIEW 9
 
-#define MEASURES_AMOUNT 8 // The total number of switches defined above
+#define MEASURES_AMOUNT 9 // The total number of switches defined above

code/_globalvars/admin.dm

@@ -28,6 +28,3 @@ GLOBAL_LIST_INIT(vv_special_lists, init_special_list_names())
 		if(isnull(locate(REF(value))))
 			output += varname
 	return output
-
-/// Disable rendering icon previews in VV.
-GLOBAL_VAR_INIT(debug_disable_vv_icon_render, FALSE)

code/modules/admin/verbs/admingame.dm

@@ -458,6 +458,7 @@ Traitors and the like can also be revived with the previous role mostly intact.
 	dat += "<br/><b>SET ALL MEASURES: <a href='?_src_=holder;[HrefToken()];change_lag_switch=ALL_ON'>ON</a> | <a href='?_src_=holder;[HrefToken()];change_lag_switch=ALL_OFF'>OFF</a></b><br/>"
 	dat += "<br/>Disable ghosts zoom and t-ray verbs (except staff): <a href='?_src_=holder;[HrefToken()];change_lag_switch=[DISABLE_GHOST_ZOOM_TRAY]'><b>[SSlag_switch.measures[DISABLE_GHOST_ZOOM_TRAY] ? "On" : "Off"]</b></a><br/>"
 	dat += "Disable late joining: <a href='?_src_=holder;[HrefToken()];change_lag_switch=[DISABLE_NON_OBSJOBS]'><b>[SSlag_switch.measures[DISABLE_NON_OBSJOBS] ? "On" : "Off"]</b></a><br/>"
+	dat += "Disable VV Icon Preview Generation: <a href='?_src_=holder;[HrefToken()];change_lag_switch=[DISABLE_VV_ICON_PREVIEW]'><b>[SSlag_switch.measures[DISABLE_VV_ICON_PREVIEW] ? "On" : "Off"]</b></a><br/>"
 	dat += "<br/>============! MAD GHOSTS ZONE !============<br/>"
 	dat += "Disable deadmob keyLoop (except staff, informs dchat): <a href='?_src_=holder;[HrefToken()];change_lag_switch=[DISABLE_DEAD_KEYLOOP]'><b>[SSlag_switch.measures[DISABLE_DEAD_KEYLOOP] ? "On" : "Off"]</b></a><br/>"
 	dat += "==========================================<br/>"

code/modules/admin/view_variables/view_variables.dm

@@ -26,7 +26,7 @@
 	var/type = islist? /list : thing.type
 	var/no_icon = FALSE
 
-	if(!GLOB.debug_disable_vv_icon_render)
+	if(!SSlag_switch.measures[DISABLE_VV_ICON_PREVIEW])
 		if(isatom(thing))
 			sprite = getFlatIcon(thing)
 			if(!sprite)
@@ -37,8 +37,8 @@
 			sprite = icon(image_object.icon, image_object.icon_state)
 
 	var/sprite_text
-	if(GLOB.debug_disable_vv_icon_render)
-		sprite_text = "\[RENDER DISABLED\]"
+	if(SSlag_switch.measures[DISABLE_VV_ICON_PREVIEW])
+		sprite_text = span_redtext("\[RENDER DISABLED\]")
 	if(sprite)
 		hash = md5(sprite)
 		src << browse_rsc(sprite, "vv[hash].png")

html/changelogs/AutoChangeLog-pr-845.yml

@@ -1,5 +1,4 @@
 author: francinum
 delete-after: true
 changes:
-  - admin: GLOB.debug_disable_vv_icon_render can be used to disable VV's usage of
-      GetFlatIcon at runtime.
+  - admin: A Lag Switch has been added to disable VV Icon Previews.