some species lore (#1175)

Author: Kapu1178

code/modules/client/preferences/species.dm

@@ -37,10 +37,10 @@
 		var/list/diet = S.get_species_diet()
 		var/list/perks = get_species_constant_data(S.type)?[SPECIES_DATA_PERKS]
 		var/list/content = list("<div style='text-align:center'>")
-		content += S.get_species_description()
+		content += S.get_species_lore()
 		content += {"
 		<br><br>
-		<table style='min-width: 90%; margin 0 auto; border: 2px solid white'>
+		<table style='min-width: 90%; margin: 0 auto; border: 2px solid white'>
 			<th style='text-align: center;vertical-align: middle; width: 33.33%; border: 2px solid white'>
 				<span style='color: #AAFFAA'>Liked Food</span>
 			</th>
@@ -61,6 +61,7 @@
 			"}
 		content += {"
 		</table>
+		<br>
 		<table class='zebraTable' style='min-width: 90%; margin 0 auto'>
 		"}
 

code/modules/client/preferences_savefile.dm

@@ -291,11 +291,6 @@ SAVEFILE UPDATING/VERSIONING - 'Simplified', or rather, more coder-friendly ~Car
 	if(needs_update >= 0)
 		update_character(needs_update, S) //needs_update == savefile_version if we need an update (positive integer)
 
-	var/mob/dead/new_player/body = parent?.mob
-	if(istype(body))
-		spawn(-1)
-			body.npp.open()
-
 	return TRUE
 
 /datum/preferences/proc/save_character()

code/modules/codex/categories/species.dm

@@ -1,4 +1,4 @@
-/*/datum/codex_category/species
+/datum/codex_category/species
 	name = "Species"
 	desc = "Many species you may encounter on your journey."
 
@@ -7,11 +7,10 @@
 		var/species_type = GLOB.species_list[species_id]
 		var/datum/species/species = new species_type()
 		var/_name = capitalize(codex_sanitize(species.plural_form))
-		new /datum/codex_entry(
+		var/datum/codex_entry/entry = new(
 			_display_name = _name,
 			_lore_text = species.get_species_lore().Join("<br><br>"),
-			_mechanics_text = species.get_species_description()
+			_mechanics_text = species.get_species_mechanics()
 		)
-		items += _name
+		items += entry
 	return ..()
-*/

code/modules/mob/living/carbon/human/species.dm

@@ -1596,11 +1596,9 @@ GLOBAL_LIST_EMPTY(features_by_species)
  *
  * Returns a string.
  */
-/datum/species/proc/get_species_description()
+/datum/species/proc/get_species_mechanics()
 	SHOULD_CALL_PARENT(FALSE)
-
-	stack_trace("Species [name] ([type]) did not have a description set, and is a selectable roundstart race! Override get_species_description.")
-	return "No species description set, file a bug report!"
+	return "WIP"
 
 /**
  * Gets the lore behind the type of species. Can be long.
@@ -1613,8 +1611,7 @@ GLOBAL_LIST_EMPTY(features_by_species)
 	SHOULD_CALL_PARENT(FALSE)
 	RETURN_TYPE(/list)
 
-	stack_trace("Species [name] ([type]) did not have lore set, and is a selectable roundstart race! Override get_species_lore.")
-	return list("No species lore set, file a bug report!")
+	return list("WIP")
 
 /**
  * Translate the species liked foods from bitfields into strings

code/modules/mob/living/carbon/human/species_types/ethereal.dm

@@ -193,18 +193,6 @@
 		'sound/voice/ethereal/ethereal_scream_3.ogg',
 	)
 
-/datum/species/ethereal/get_species_description()
-	return "Coming from the planet of Sprout, the theocratic ethereals are \
-		separated socially by caste, and espouse a dogma of aiding the weak and \
-		downtrodden."
-
-/datum/species/ethereal/get_species_lore()
-	return list(
-		"Ethereals are a species native to the planet Sprout. \
-		When they were originally discovered, they were at a medieval level of technological progression, \
-		but due to their natural acclimation with electricity, they felt easy among the large Daedalus installations.",
-	)
-
 /datum/species/ethereal/create_pref_unique_perks()
 	var/list/to_add = list()
 

code/modules/mob/living/carbon/human/species_types/flypeople.dm

@@ -57,26 +57,6 @@
 	if(istype(attacking_item, /obj/item/melee/flyswatter))
 		damage_mods += 30 // Yes, a 30x damage modifier
 
-/datum/species/fly/get_species_description()
-	return "With no official documentation or knowledge of the origin of \
-		this species, they remain a mystery to most. Any and all rumours among \
-		Nanotrasen staff regarding flypeople are often quickly silenced by high \
-		ranking staff or officials."
-
-/datum/species/fly/get_species_lore()
-	return list(
-		"Flypeople are a curious species with a striking resemblance to the insect order of Diptera, \
-		commonly known as flies. With no publically known origin, flypeople are rumored to be a side effect of bluespace travel, \
-		despite statements from Nanotrasen officials.",
-
-		"Little is known about the origins of this race, \
-		however they posess the ability to communicate with giant spiders, originally discovered in the Australicus sector \
-		and now a common occurence in black markets as a result of a breakthrough in syndicate bioweapon research.",
-
-		"Flypeople are often feared or avoided among other species, their appearance often described as unclean or frightening in some cases, \
-		and their eating habits even more so with an insufferable accent to top it off.",
-	)
-
 /datum/species/fly/create_pref_unique_perks()
 	var/list/to_add = list()
 

code/modules/mob/living/carbon/human/species_types/humans.dm

@@ -21,28 +21,12 @@
 	human.hair_color = "#bb9966" // brown
 	human.update_body_parts()
 
-/datum/species/human/get_species_description()
-	return "Humans are the dominant species in the known galaxy. \
-		Their kind extend from old Earth to the edges of known space."
+/datum/species/human/get_species_mechanics()
+	return "Humans possess no unique traits."
 
 /datum/species/human/get_species_lore()
 	return list(
-		"These primate-descended creatures, originating from the mostly harmless Earth, \
-		have long-since outgrown their home and semi-benign designation. \
-		The space age has taken humans out of their solar system and into the galaxy-at-large.",
-
-		"In traditional human fashion, this near-record pace from terra firma to the final frontier spat \
-		in the face of other races they now shared a stage with. \
-		This included the lizards - if anyone was offended by these upstarts, it was certainly lizardkind.",
-
-		"Humanity never managed to find the kind of peace to fully unite under one banner like other species. \
-		The pencil and paper pushing of the UN bureaucrat lives on in the mosaic that is TerraGov; \
-		a composite of the nation-states that still live on in human society.",
-
-		"The human spirit of opportunity and enterprise continues on in its peak form: \
-		the hypercorporation. Acting outside of TerraGov's influence, literally and figuratively, \
-		hypercorporations buy the senate votes they need and establish territory far past the Earth Government's reach. \
-		In hypercorporation territory company policy is law, giving new meaning to \"employee termination\".",
+		"Humanity. Adaptable, numerous, resiliant, and viral.",
 	)
 
 /datum/species/human/get_agony_sound(mob/living/carbon/human)

code/modules/mob/living/carbon/human/species_types/ipc.dm

@@ -70,6 +70,7 @@
 
 /datum/species/ipc/saurian
 	name = "Integrated Positronic Chassis (Jinan)"
+	plural_form = "Integrated Positronic Chassis (Jinan)"
 	id = SPECIES_SAURIAN
 	species_traits = list(NOEYESPRITES, MUTCOLORS, NOBLOOD, NOZOMBIE, NO_UNDERWEAR, NO_DNA_COPY, NOTRANSSTING, AGENDER, EYECOLOR)
 	cosmetic_organs = list(

code/modules/mob/living/carbon/human/species_types/lizardpeople.dm

@@ -129,33 +129,13 @@
 		'sound/voice/lizard/lizard_scream_3.ogg',
 	)
 
-/datum/species/lizard/get_species_description()
-	return {"
-		The peaceful Jinan people originate from the planet Jitarai.
-		They are adept with robotics and artifical intelligence,
-		which is how their governing body came to be an AI known as Companion.
-		"}
+/datum/species/lizard/get_species_mechanics()
+	return "Cold blooded, with poor thermoregulation."
 
 /datum/species/lizard/get_species_lore()
 	return list(
-		"The face of conspiracy theory was changed forever the day mankind met the lizards.",
-
-		"Jinans are a species of intelligent humanoid reptiles from the planet Jitarai. They are most known for \
-		their innovation in the field of robotics, at the time of first contact, they were over one hundred years \
-		ahead of Humanity. Jitarai has one governing body, a century year old artificial intelligence known as Companion. \
-		Developed by the Old Jinar (Great Ones) to lead their people to greatness, Companion succeeded it's goal \
-		and united the planet under one government. Despite the success of the Companion project, some of the Jinan people \
-		have a distrust in their artificial leader. Many seek to leave the planet as soon as they acquire means, be it out of fear \
-		or disgust that their people are controlled by a machine. The way the government operates is not fully known, \
-		with some outsiders theorizing there is a Jinan council that maintains Companion.",
-
-		"The Jinan people created and popularized the Integrated Positronic Chassis (IPC), a fully autonomous robot capable \
-		of performing the same tasks as a normal person. Their primary export is robotics equipment, industrial equipment, and positronic brains. \
-		Many companies from Earth have created their own versions of IPCs, and sell them on the market with middling success.",
-
-		"Jinans were the first species to be discovered by Humanity, with their probe having crash landed onto Mercury in 1953, \
-		sparking the Space Race. Eventually, contact was made by the United States, and a positive relationship quickly \
-		developed between the two peoples. ",
+		"Highly intelligent reptilian humanoids from a planet ruled by an artificial intelligence named Friend Computer. \
+		Creators of the most advanced prosthetics and A.I technology."
 	)
 
 // Override for the default temperature perks, so we can give our specific "cold blooded" perk.

code/modules/mob/living/carbon/human/species_types/monkeys.dm

@@ -85,18 +85,6 @@
 		'sound/creatures/monkey/monkey_screech_7.ogg',
 	)
 
-/datum/species/monkey/get_species_description()
-	return "Monkeys are a type of primate that exist between humans and animals on the evolutionary chain. \
-		Every year, on Monkey Day, Nanotrasen shows their respect for the little guys by allowing them to roam the station freely."
-
-/datum/species/monkey/get_species_lore()
-	return list(
-		"Monkeys are commonly used as test subjects on board Space Station Thirteen. \
-		But what if... for one day... the Monkeys were allowed to be the scientists? \
-		What experiments would they come up it? Would they (stereotypically) be related to bananas somehow? \
-		There's only one way to find out.",
-	)
-
 /datum/species/monkey/create_pref_unique_perks()
 	var/list/to_add = list()
 

code/modules/mob/living/carbon/human/species_types/mothmen.dm

@@ -86,28 +86,6 @@
 /datum/species/moth/get_scream_sound(mob/living/carbon/human/human)
 	return 'sound/voice/moth/scream_moth.ogg'
 
-/datum/species/moth/get_species_description()
-	return "The Gamuioda, also known as Mothpeople in various sectors due to their appearance, are a species hailing from the planet Paraco in the Orion Spur. \
-		The Gamuioda are a large part of labour within various space stations and shuttles, providing materials, fuel, parts, and produce."
-
-/datum/species/moth/get_species_lore()
-	return list(
-		"The native language of Gamuioda is referred to as 'Gamuid' by their population. However, 'Moffic' is used as an exonym among other species.",
-
-		"Written transcripts of Gamuioda history remain largely untranslated to modern Gamuid, that most of the populace knows. \
-		However, more recent transcripts detail the progress of Gamuioda working to accelerate the process of first contact - to get in touch with extra-terrestrials. \
-		There is a long history of research and scientific development done by Gamuioda, with lower-class Gamuioda focusing on providing materials and other needed produce for upper-class researchers to utilize in advancements.",
-
-		"Upon meeting other lifeforms outside of their planet, notably Humans, the Gamuioda would begin to offer their population as a labor force for stations, ships, and other facilities requiring employment. \
-		There wasn't a fixed paycheck at first for moths when they first began work. This led to an economic crisis and a huge spike in inflation on their homeworld when converting credits into their currency, the Posis, \
-		With some careful consideration, Gamuioda working on Nanotrasen facilities are paid 20% less than most, and are given a weekly lamp to supplement the unpaid money. \
-		This has pleased 98% of surveyed moths, including the upper class.",
-
-		"The working, lower, and upper classes of Gamuioda are scattered across their homeworld of Paraco, including other under-studied planets, with the wealthy more focused on settling down in rain forests, primarily to take shelter in tall trees. \
-		The variety in weather and temperature endemic to Paraco has given rise to a vast amount of clothing styles, with a key focus on embroidered designs on cloth, \
-		though most often those working on stations and other facilities wear heavy-duty equipment or their assigned uniforms.",
-	)
-
 /datum/species/moth/create_pref_unique_perks()
 	var/list/to_add = list()
 

code/modules/mob/living/carbon/human/species_types/shadowpeople.dm

@@ -54,27 +54,6 @@
 		return TRUE
 	return ..()
 
-/datum/species/shadow/get_species_description()
-	return "Victims of a long extinct space alien. Their flesh is a sickly \
-		seethrough filament, their tangled insides in clear view. Their form \
-		is a mockery of life, leaving them mostly unable to work with others under \
-		normal circumstances."
-
-/datum/species/shadow/get_species_lore()
-	return list(
-		"Long ago, the Spinward Sector used to be inhabited by terrifying aliens aptly named \"Shadowlings\" \
-		after their control over darkness, and tendancy to kidnap victims into the dark maintenance shafts. \
-		Around 2558, the long campaign Nanotrasen waged against the space terrors ended with the full extinction of the Shadowlings.",
-
-		"Victims of their kidnappings would become brainless thralls, and via surgery they could be freed from the Shadowling's control. \
-		Those more unlucky would have their entire body transformed by the Shadowlings to better serve in kidnappings. \
-		Unlike the brain tumors of lesser control, these greater thralls could not be reverted.",
-
-		"With Shadowlings long gone, their will is their own again. But their bodies have not reverted, burning in exposure to light. \
-		Nanotrasen has assured the victims that they are searching for a cure. No further information has been given, even years later. \
-		Most shadowpeople now assume Nanotrasen has long since shelfed the project.",
-	)
-
 /datum/species/shadow/create_pref_unique_perks()
 	var/list/to_add = list()
 

code/modules/mob/living/carbon/human/species_types/skeletons.dm

@@ -64,15 +64,3 @@
 	if(SSevents.holidays && SSevents.holidays[HALLOWEEN])
 		return TRUE
 	return ..()
-
-/datum/species/skeleton/get_species_description()
-	return "A rattling skeleton! They descend upon Space Station 13 \
-		Every year to spook the crew! \"I've got a BONE to pick with you!\""
-
-/datum/species/skeleton/get_species_lore()
-	return list(
-		"Skeletons want to be feared again! Their presence in media has been destroyed, \
-		or at least that's what they firmly believe. They're always the first thing fought in an RPG, \
-		they're Flanderized into pun rolling JOKES, and it's really starting to get to them. \
-		You could say they're deeply RATTLED. Hah."
-	)

code/modules/mob/living/carbon/human/species_types/teshari.dm

@@ -107,17 +107,6 @@
 		return random_unique_teshari_name()
 	return teshari_name()
 
-/datum/species/teshari/get_species_description()
-	return "The Teshari are a species of social, pack-based raptor-like nomadic aliens, hailing from the planet of Esmerini, or Penelope's Star VII (7), \
-	a cold jungle planet full of precursor and archotechnology just outside the Goldilocks zone of their system. While still a relatively young species, \
-	the Teshari have become a recent part of spacefaring species, thanks in part to efforts by the Orion Commonwealth to uplift them, \
-	trading the snow-filled trees and frozen tundra for warmer ships and orbital installations."
-
-/datum/species/teshari/get_species_lore()
-	return list(
-		"WIP"
-	)
-
 /datum/species/teshari/on_species_gain(mob/living/carbon/C, datum/species/old_species, pref_load)
 	. = ..()
 	ADD_WADDLE(C, WADDLE_SOURCE_TESHARI)

code/modules/mob/living/carbon/human/species_types/vampire.dm

@@ -95,16 +95,6 @@
 /datum/species/vampire/get_random_blood_type()
 	return /datum/blood/universal
 
-/datum/species/vampire/get_species_description()
-	return "A classy Vampire! They descend upon Space Station Thirteen Every year to spook the crew! \"Bleeg!!\""
-
-/datum/species/vampire/get_species_lore()
-	return list(
-		"Vampires are unholy beings blessed and cursed with The Thirst. \
-		The Thirst requires them to feast on blood to stay alive, and in return it gives them many bonuses. \
-		Because of this, Vampires have split into two clans, one that embraces their powers as a blessing and one that rejects it.",
-	)
-
 // Vampire blood is special, so it needs to be handled with its own entry.
 /datum/species/vampire/create_pref_blood_perks()
 	var/list/to_add = list()

code/modules/mob/living/carbon/human/species_types/vox.dm

@@ -113,26 +113,13 @@
 
 	return randname
 
-/datum/species/vox/get_species_description()
-	return "'The Vox' refers to, in most sectors, the most commonly seen type: Vox Primalis. A peculiar hybrid of reptilian and avian characteristics hailing from massive space vessels often known as Arkships. \
-		Most work with utter loyalty to their creators, the Vox Auralis, though some have been known to reject it entirely and try to shape their own lives, but this is an uncommon occurrence. \
-		Either way, regardless of their loyalty to their creators, Vox are condemned to an eternity of life so long as their stack exists and can be placed in a new gene form, \
-		and the pigmented serial upon them will always be a reminder of their artificial origins."
+/datum/species/vox/get_species_mechanics()
+	return "Oxygen is poisonous to Vox, requiring them to use respirators connected to a source of Nitrogen."
 
 /datum/species/vox/get_species_lore()
 	return list(
-		"The Vox hail from massive, planetoid-like ships known simply as Arks. They drift silently through the universe, and have seemingly existed since before the rise of most space-faring species of the modern era. \
-		Each Primalis is created with a pre-determined destiny in mind, a function that they will fulfill until the end of their body's lifetime, whereupon they have their cortical stack extracted and implanted into a new larval form. \
-		This new body will grow into the Vox according to the encoded genetic data, preserving the skills and recreating a body best fitting for their function.",
-
-		"Historically, the Arks have been mostly silent to the majority of species, beyond the occasional garbled warning about approaching, or the smallest of trades and exchanges. \
-		This has changed in recent years, with several Arkships opening communications with Nanotrasen, with discussions behind closed doors. \
-		One of the first long-term deals with the Vox came in the form of a charity named Val-Biotechnica, created and sponsored by Nanotrasen. Using advanced Vox bio-technology to provide healthcare and genetic therapy at low to no cost.",
-
-		"Conspiracy theorists have suggested that this Vox charity is a guise for kidnappings and harvestings, though Nanotrasen denies all claims, as does Val-Biotechnica. \
-		A labor deal was also reached, allowing Ark-Vox to work for Nanotrasen, which can be difficult for those Vox now having to adjust to the inorganic nature of non-Vox technology. \
-		Their presence brings some conflict between Ark-Vox and the Free-Vox who have fled from their creators and their homes, living in places such as The Shoal, or any station that will accept them. \
-		Nanotrasen Public Relations takes great care in assuring the public that everything is fine, and that they're working in perfect harmony.",
+		"A reclusive race of tall humanoid nomads, rare to see in person. Most Vox have been observed to be highly xenophobic and unwilling to share information about their kind. \
+		They possess a strong attraction to material goods, with the vast majority of known Vox being acclaimed tradesmen or pirates."
 	)
 
 /datum/species/vox/get_scream_sound(mob/living/carbon/human/vox)

code/modules/mob/living/carbon/human/species_types/zombies.dm

@@ -71,12 +71,6 @@
 		return TRUE
 	return ..()
 
-/datum/species/zombie/get_species_description()
-	return "A rotting zombie! They descend upon Space Station Thirteen Every year to spook the crew! \"Sincerely, the Zombies!\""
-
-/datum/species/zombie/get_species_lore()
-	return list("Zombies have long lasting beef with Botanists. Their last incident involving a lawn with defensive plants has left them very unhinged.")
-
 // Override for the default temperature perks, so we can establish that they don't care about temperature very much
 /datum/species/zombie/create_pref_temperature_perks()
 	var/list/to_add = list()