adds more logging to game start failures (#1196)

Author: Kapu1178

code/controllers/subsystem/job.dm

@@ -438,6 +438,7 @@ SUBSYSTEM_DEF(job)
 
 	. = assign_captain()
 	if(!.)
+		SSticker.mode.setup_error += "Failed to assign captain. See JobDebug for more information."
 		return FALSE
 
 	//People who wants to be the overflow role, sure, go on.
@@ -528,6 +529,7 @@ SUBSYSTEM_DEF(job)
 			if(!AssignRole(player, GetJobType(overflow_role))) //If everything is already filled, make them an assistant
 				JobDebug("DO, Forced antagonist could not be assigned any random job or the overflow role. DivideOccupations failed.")
 				JobDebug("---------------------------------------------------")
+				SSticker.mode.setup_error += "An unassigned player could not be given a random or overflow role. See JobDebug for more information."
 				return FALSE //Living on the edge, the forced antagonist couldn't be assigned to overflow role (bans, client age) - just reroll
 
 	JobDebug("DO, Ending handle unrejectable unassigned")
@@ -543,6 +545,8 @@ SUBSYSTEM_DEF(job)
 					we_fucked = TRUE
 
 			if(we_fucked)
+				JobDebug("DO, could not fill all departments.")
+				SSticker.mode.setup_error += "Could not fill all required departments. See JobDebug for more information."
 				return FALSE
 
 			JobDebug("DO, all departments have atleast one player.")
@@ -1076,12 +1080,12 @@ SUBSYSTEM_DEF(job)
 		for(var/rank in required_group)
 			var/datum/job/J = GetJob(rank)
 			if(!J)
-				SSticker.mode.setup_error = "Invalid job [rank] in gamemode required jobs."
+				SSticker.mode.setup_error += "Invalid job [rank] in gamemode required jobs."
 				return FALSE
 			if(J.current_positions < required_group[rank])
 				group_ok = FALSE
 				break
 		if(group_ok)
 			return TRUE
-	SSticker.mode.setup_error = "Required jobs not present."
+	SSticker.mode.setup_error += "Required jobs not present."
 	return FALSE

code/controllers/subsystem/ticker.dm

@@ -832,8 +832,8 @@ SUBSYSTEM_DEF(ticker)
 
 	if(!GLOB.Debug2)
 		if(!can_continue)
-			log_game("[get_mode_name(TRUE)] failed pre_setup, cause: [mode.setup_error].")
-			message_admins("[get_mode_name(TRUE)] failed pre_setup, cause: [mode.setup_error].")
+			log_game("[get_mode_name(TRUE)] failed pre_setup, cause(s): [english_list(mode.setup_error)].")
+			message_admins("[get_mode_name(TRUE)] failed pre_setup, cause(s): [english_list(mode.setup_error)].")
 			to_chat(world, "<B>Error setting up [get_mode_name(TRUE)].</B> Reverting to pre-game lobby.")
 			mode.on_failed_execute()
 			QDEL_NULL(mode)

code/game/gamemodes/game_mode.dm

@@ -21,8 +21,8 @@
 	///Is the gamemode votable? !Not implimented!
 	var/votable = FALSE
 
-	///Dynamically set to what the problem was. Or the first problem, anyway.
-	var/setup_error = ""
+	///Dynamically set to what the problem(s) was/were.
+	var/list/setup_error = list()
 
 	///The minimum players this gamemode can roll
 	var/min_pop = 1
@@ -82,14 +82,14 @@
 /datum/game_mode/proc/execute_roundstart()
 	SHOULD_CALL_PARENT(TRUE)
 	if(!pre_setup())
-		setup_error ||= "Failed pre_setup."
+		setup_error += "Failed pre_setup."
 		return FALSE
 
 	antagonists = GLOB.pre_setup_antags.Copy()
 	GLOB.pre_setup_antags.Cut()
 	var/number_of_antags = length(antagonists)
 	if(number_of_antags < required_enemies)
-		setup_error = "Not enough antagonists selected. Required [required_enemies], got [number_of_antags]."
+		setup_error += "Not enough antagonists selected. Required [required_enemies], got [number_of_antags]."
 		return FALSE
 
 	return TRUE
@@ -124,7 +124,7 @@
 	// Strip out antag bans/people without this antag as a pref
 	trim_candidates(possible_antags)
 	if(!length(possible_antags))
-		setup_error = "No possible antagonists found"
+		setup_error += "No possible antagonists found"
 		return FALSE
 	return TRUE