Pickpocketing Backpacks (#1146)

* pick pocketing

* OVER-REACHING RENAME

* make pickpocket code better

* fix

* qol

* idk how this can happen but just in case

* fuck

* rangedreachcheck

* unzip backpack

* add controls text

* fix

Author: Kapu1178

code/__DEFINES/flags.dm

@@ -282,19 +282,21 @@ GLOBAL_LIST_INIT(bitflags, list(1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 204
 
 // timed_action_flags parameter for `/proc/do_after_mob`, `/proc/do_mob` and `/proc/do_after`
 /// Can do the action even if mob moves location
-#define IGNORE_USER_LOC_CHANGE (1<<0)
+#define DO_IGNORE_USER_LOC_CHANGE (1<<0)
 /// Can do the action even if the target moves location
-#define IGNORE_TARGET_LOC_CHANGE (1<<1)
+#define DO_IGNORE_TARGET_LOC_CHANGE (1<<1)
 /// Can do the action even if the item is no longer being held
-#define IGNORE_HELD_ITEM (1<<2)
+#define DO_IGNORE_HELD_ITEM (1<<2)
 /// Can do the action even if the mob is incapacitated (ex. handcuffed)
-#define IGNORE_INCAPACITATED (1<<3)
+#define DO_IGNORE_INCAPACITATED (1<<3)
 /// Used to prevent important slowdowns from being abused by drugs like kronkaine
-#define IGNORE_SLOWDOWNS (1<<4)
+#define DO_IGNORE_SLOWDOWNS (1<<4)
+/// Used to prevent rotation by the user.
+#define DO_RESTRICT_USER_DIR_CHANGE (1<<5)
 /// If the user has their next_move value changed (usually by clicking), fail.
-#define DO_RESTRICT_CLICKING (1<<5)
+#define DO_RESTRICT_CLICKING (1<<6)
 /// Shown to all mobs not just the user
-#define DO_PUBLIC (1<<6)
+#define DO_PUBLIC (1<<7)
 
 
 

code/__DEFINES/traits.dm

@@ -617,6 +617,8 @@ Remember to update _globalvars/traits.dm if you're adding/removing/renaming trai
 #define TRAIT_HIDES_VOICE "hides_voice"
 /// Wearing this item in the mask slot will make your voice your current ID, or unknown
 #define TRAIT_REPLACES_VOICE "replaces_voice"
+/// Pickpocketing this item takes no time.
+#define TRAIT_INSTANT_PICKPOCKET "instant_pickpocket"
 
 //quirk traits
 #define TRAIT_ALCOHOL_TOLERANCE "alcohol_tolerance"

code/_onclick/click.dm

@@ -256,6 +256,22 @@
 /atom/movable/IsContainedAtomAccessible(atom/contained, atom/movable/user)
 	return !!atom_storage
 
+/mob/living/IsContainedAtomAccessible(atom/contained, atom/movable/user)
+	. = ..()
+	if(.)
+		return
+
+	if(!isliving(user))
+		return
+
+	if(!isitem(contained))
+		return
+
+	var/mob/living/living_user = user
+	var/obj/item/I = contained
+	if(I.can_pickpocket(user))
+		return I.atom_storage == living_user.active_storage
+
 /atom/movable/proc/DirectAccess()
 	return list(src, loc)
 
@@ -390,6 +406,8 @@
 	if(!can_interact(user))
 		return FALSE
 
+	return TRUE
+
 /mob/living/CtrlClick(mob/user, list/params)
 	if(!isliving(user) || !IsReachableBy(user) || user.incapacitated())
 		return ..()

code/datums/components/cult_ritual_item.dm

@@ -311,7 +311,7 @@
 		scribe_mod *= 0.5
 
 	SEND_SOUND(cultist, sound('sound/weapons/slice.ogg', 0, 1, 10))
-	if(!do_after(cultist, get_turf(cultist), scribe_mod, timed_action_flags = IGNORE_SLOWDOWNS))
+	if(!do_after(cultist, get_turf(cultist), scribe_mod, timed_action_flags = DO_IGNORE_SLOWDOWNS))
 		cleanup_shields()
 		return FALSE
 	if(!can_scribe_rune(tool, cultist))

code/datums/components/food/edible.dm

@@ -310,7 +310,7 @@ Behavior that's still missing from this component that original food items had t
 	var/fullness = eater.get_fullness() + 10 //The theoretical fullness of the person eating if they were to eat this
 
 	if(eater == feeder)//If you're eating it yourself.
-		if(eat_time && !do_after(feeder, eater, eat_time, timed_action_flags = food_flags & FOOD_FINGER_FOOD ? IGNORE_USER_LOC_CHANGE | IGNORE_TARGET_LOC_CHANGE : NONE)) //Gotta pass the minimal eat time
+		if(eat_time && !do_after(feeder, eater, eat_time, timed_action_flags = food_flags & FOOD_FINGER_FOOD ? DO_IGNORE_USER_LOC_CHANGE | DO_IGNORE_TARGET_LOC_CHANGE : NONE)) //Gotta pass the minimal eat time
 			return
 		if(IsFoodGone(owner, feeder))
 			return

code/datums/elements/strippable.dm

@@ -182,13 +182,13 @@
 /// Returns the ID of this item's strippable action.
 /// Return `null` if there is no alternate action.
 /// Any return value of this must be in StripMenu.
-/datum/strippable_item/proc/get_alternate_action(atom/source, mob/user)
+/datum/strippable_item/proc/get_alternate_action(atom/source, mob/user, action)
 	return null
 
 /// Performs an alternative action on this strippable_item.
 /// `has_alternate_action` needs to be TRUE.
 /// Returns FALSE if blocked by signal, TRUE otherwise.
-/datum/strippable_item/proc/alternate_action(atom/source, mob/user)
+/datum/strippable_item/proc/alternate_action(atom/source, mob/user, action)
 	SHOULD_CALL_PARENT(TRUE)
 	if(SEND_SIGNAL(user, COMSIG_TRY_ALT_ACTION, source) & COMPONENT_CANT_ALT_ACTION)
 		return FALSE
@@ -483,7 +483,7 @@
 			LAZYORASSOCLIST(interactions, user, key)
 
 			// Potentially yielding
-			strippable_item.alternate_action(owner, user)
+			strippable_item.alternate_action(owner, user, params["action"])
 
 			LAZYREMOVEASSOC(interactions, user, key)
 

code/datums/storage/storage.dm

@@ -163,7 +163,7 @@
 	RegisterSignal(parent, COMSIG_ITEM_ATTACK_SELF, PROC_REF(mass_empty))
 	RegisterSignal(parent, list(COMSIG_CLICK_ALT, COMSIG_ATOM_ATTACK_GHOST, COMSIG_ATOM_ATTACK_HAND_SECONDARY), PROC_REF(open_storage_on_signal))
 	RegisterSignal(parent, COMSIG_PARENT_ATTACKBY_SECONDARY, PROC_REF(open_storage_attackby_secondary))
-	RegisterSignal(parent, COMSIG_MOVABLE_MOVED, PROC_REF(close_distance))
+	RegisterSignal(parent, COMSIG_MOVABLE_MOVED, PROC_REF(update_viewability))
 	RegisterSignal(parent, COMSIG_ITEM_EQUIPPED, PROC_REF(update_actions))
 
 /datum/storage/proc/on_deconstruct()
@@ -769,6 +769,9 @@ GLOBAL_LIST_EMPTY(cached_storage_typecaches)
 
 	remove_all(dump_loc)
 
+/datum/storage/proc/is_reachable(mob/user)
+	return parent.IsReachableBy(user)
+
 /// Signal handler for whenever something gets mouse-dropped onto us.
 /datum/storage/proc/on_mousedropped_onto(datum/source, obj/item/dropping, mob/user)
 	SIGNAL_HANDLER
@@ -924,15 +927,15 @@ GLOBAL_LIST_EMPTY(cached_storage_typecaches)
 	return COMPONENT_NO_AFTERATTACK
 
 /// Opens the storage to the mob, showing them the contents to their UI.
-/datum/storage/proc/open_storage(mob/to_show, performing_quickdraw)
+/datum/storage/proc/open_storage(mob/to_show, performing_quickdraw, skip_canreach = FALSE)
 	if(isobserver(to_show))
 		if(to_show.active_storage == src)
 			hide_contents(to_show)
 		else
 			show_contents(to_show)
 		return FALSE
 
-	if(!can_be_reached_by(to_show))
+	if(!skip_canreach && !can_be_reached_by(to_show))
 		to_chat(to_show, span_warning("You cannot reach [parent]."))
 		return FALSE
 
@@ -980,8 +983,8 @@ GLOBAL_LIST_EMPTY(cached_storage_typecaches)
 			to_chat(toshow, span_notice("You fumble for [toremove] and it falls on the floor."))
 		return TRUE
 
-/// Signal handler for whenever a mob walks away with us, close if they can't reach us.
-/datum/storage/proc/close_distance(datum/source)
+/// Close the storage for people who can no longer see it.
+/datum/storage/proc/update_viewability(datum/source)
 	SIGNAL_HANDLER
 
 	for(var/mob/user in can_see_contents())

code/game/atoms.dm

@@ -1164,8 +1164,13 @@
  */
 /atom/proc/setDir(newdir)
 	SHOULD_CALL_PARENT(TRUE)
+	if(newdir == dir)
+		return null
+
+	. = dir
 	SEND_SIGNAL(src, COMSIG_ATOM_DIR_CHANGE, dir, newdir)
 	dir = newdir
+	return .
 
 /**
  * Called when the atom log's in or out

code/game/objects/items.dm

@@ -1894,3 +1894,7 @@ DEFINE_INTERACTABLE(/obj/item)
 	center["x"] = text2num(center["x"])
 	center["y"] = text2num(center["y"])
 	return center
+
+/// Returns TRUE if the passed mob can interact with this item's storage via pickpocketing.
+/obj/item/proc/can_pickpocket(mob/living/user)
+	return FALSE

code/game/objects/items/bodybag.dm

@@ -80,7 +80,7 @@
 	user.last_special = world.time + CLICK_CD_BREAKOUT
 	to_chat(user, span_notice("You claw at the fabric of [src], trying to tear it open..."))
 	to_chat(loc, span_warning("Someone starts trying to break free of [src]!"))
-	if(!do_after(user, src, 12 SECONDS, timed_action_flags = (IGNORE_TARGET_LOC_CHANGE|IGNORE_HELD_ITEM)))
+	if(!do_after(user, src, 12 SECONDS, timed_action_flags = (DO_IGNORE_TARGET_LOC_CHANGE|DO_IGNORE_HELD_ITEM)))
 		return
 	// you are still in the bag? time to go unless you KO'd, honey!
 	// if they escape during this time and you rebag them the timer is still clocking down and does NOT reset so they can very easily get out.