I was wondering why dyanmic lighting looked so weird when I've been playing to the point I'd rather have it be disabled all together :(

I wish I could use the old forward renderer 😄

I don't really have an opinion on this since

1. I have never seen it working;
2. I don't know that part of the code so I don't know how useful or useless this can be as a reference implementation to be ported;
3. I don't know how much of a maintenance pain it can be.

I think if you want to nuke it it probably means it's not worth keeping it around as you try hard to keep legacy code.

In fact I thought the legacy renderer was already dropped.

To remove confusions:

In fact I thought the legacy renderer was already dropped.

There was two things:

• The Legacy OpenGL 1 renderer
• The Modern OpenGL 3 renderer

Those were even two separate code trees, two separate libraries. We dropped the first one a decade ago.

Then, in the remaining Modern OpenGL 3 renderer, there is the part that is used to render lights and things like that, it's more a subset of the whole “Modern OpenGL 3 renderer”, it's a set of functions and a different code path.

So let's say we have two code paths in the “Modern OpenGL 3 renderer” and we may NUKE one of them.

This can be done once the required features from #1209 are implemented.

From an earlier IRC discussion: this also requires adding CPU dynamic light culling code for devices that cannot run the lighttile code due to ALU limitations. Possibly also for hardware lacking certain required extensions, in which case we can have a macro bypassing the tile fetching code, using a small array of dynamic lights instead.

Additionally, instead of culling the lights we can set some of them as high-priority, e. g. indicators on maps or flashlights (if we had them), and then only process those.