Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation on the best way to integrate UV in a custom theme #9

Open
symac opened this issue Oct 29, 2019 · 0 comments
Open

Comments

@symac
Copy link

symac commented Oct 29, 2019

According to #2 there should now be no issue using French to display the UV but either there is still a bug, either I have not understood how to do.

What I am doing right now in my custom theme is:

echo $this->universalViewer($item, ["locales" => [['name' => 'fr-FR', 'label' => 'French']]])

But UV won't display in French. I have found that it is because of the $config += $options; that is used at https://github.com/Daniel-KM/Omeka-S-module-UniversalViewer/blob/master/src/View/Helper/UniversalViewer.php#L217

As $config['locales'] is already set just above this line, my $options are not taken into account. I have found this to work if I change $config += $options; to $config = array_merge($config, $options);.

But I am not sure if I need to do this because I have called correctly UV from my theme (then, some more documentation would be welcome) or if there is an actual code that my small change can fix (then feel free to integrate it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant