Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to mark pictures to be excluded in customer report #119

Open
scaspers opened this issue Jun 20, 2018 · 2 comments
Open

Ability to mark pictures to be excluded in customer report #119

scaspers opened this issue Jun 20, 2018 · 2 comments
Labels
Feature Nice To Have Desired for shipping with a version, but may get negotiated out to a future version

Comments

@scaspers
Copy link
Collaborator

scaspers commented Jun 20, 2018 •
edited
Loading

We currently have the ability to delete unwanted pictures but there is the desire to have some pictures saved for our own use and reference but not include them in the customer report.
@scaspers scaspers added this to the v2.0 milestone Jun 20, 2018
@scaspers scaspers changed the title Ability to mark pictures to be included in customer report Ability to mark pictures to be excluded in customer report Jun 20, 2018
@DanielCaspers DanielCaspers modified the milestones: v2.0, V1.2 Jun 30, 2018
@DanielCaspers DanielCaspers mentioned this issue Jun 30, 2018
Closed
@DanielCaspers DanielCaspers added the Nice To Have Desired for shipping with a version, but may get negotiated out to a future version label Jun 30, 2018
@DanielCaspers
Copy link
Owner

@scaspers @YoMurphy Is there ever a chance you'd want images visible to customer only? I assume not, but wanted to check.

DanielCaspers added a commit that referenced this issue Jul 21, 2018
@DanielCaspers
feat(#119 - Inspection Images) - Ability to exclude in customer report
eae8edc
@DanielCaspers
Copy link
Owner

Feature still requires the user to be able to toggle image visibility from the service adviser portal, so they never have to open the inspection in DI ideally. Previously committed functionality can stay.

@DanielCaspers DanielCaspers modified the milestones: V1.2, v1.3 Sep 8, 2018
@DanielCaspers DanielCaspers removed this from the v1.3 milestone Jul 4, 2019
DanielCaspers added a commit that referenced this issue Feb 20, 2022
@DanielCaspers
feat(#119 - Inspection Items) - Add Video Support
0c5991c 
Videos can be uploaded in addition to images. This means uploaded videos can be...
- previewed prior to upload
- viewed alongside images afterwards
- visbile to/hidden from customers, when appropriate

Additional features:
- On dismissing a dialog playing a video, the video is removed from the DOM (so it isn't consuming CPU)
- On moving carousel forward or backward with a video in it, the video will be paused.
- On selecting an image for upload, the file size is displayed (to help tune the max upload size and have some idea how long to wait for form upload)

Miscellaneous Improvements:
- Removes image compression (was unused)
- Warns if an unsupported media type which cannot be rendered is uploaded after form submission.
DanielCaspers added a commit that referenced this issue Feb 20, 2022
@DanielCaspers
feat(#119 - Inspection Items) - Add Video Support
648b6ef 
- Fix autopause on prev or next carousel item slide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Nice To Have Desired for shipping with a version, but may get negotiated out to a future version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielCaspers @scaspers