[p] Adopt mypy (#6821, PR #6854)

Author: hannes-ucsc

.github/workflows/ci.yml

@@ -138,13 +138,12 @@ jobs:
           cache: 'pip'
           cache-dependency-path: 'requirements.dev.txt'
 
-      - uses: 'github/codeql-action/init@v2'
+      - uses: 'github/codeql-action/init@v3'
         with:
           languages: '${{ matrix.language }}'
-          setup-python-dependencies: false
           config-file: './.github/codeql/codeql-config.yml'
           queries: 'security-and-quality'
 
-      - uses: 'github/codeql-action/analyze@v2'
+      - uses: 'github/codeql-action/analyze@v3'
         with:
           category: '/language:${{matrix.language}}'

.mypy.ini

@@ -11,12 +11,24 @@ modules =
     azul.azulclient,
     azul.bytes,
     azul.caching,
-    azul.chalice
+    azul.chalice,
+    azul.bigquery,
+    azul.bigquery_reservation,
+    azul.csp,
+    azul.deployment,
+    azul.strings,
+    azul.logging,
+    azul,
+    azul.docker
 packages =
     azul.openapi
 
 [mypy-furl.*]
 follow_untyped_imports = True
 
 [mypy-requests.*]
-follow_untyped_imports = True
+follow_untyped_imports = True
+
+[mypy-docker.*]
+; https://github.com/python/typeshed/issues/13439
+follow_untyped_imports = True

CONTRIBUTING.rst

@@ -397,10 +397,12 @@ Ordering artifacts in the source
 Disabling sections of code
 --------------------------
 
-* To temporarily disable a section of code, we embed it in a conditional
-  statement with an test that always evaluates to false (``if False:`` in
-  Python) instead of commenting that section out. We do this to keep the code
-  subject to refactorings and code inspection tools.
+* We do not comment out sections of code. To temporarily disable some section of
+  code, we embed it in a conditional statement with a test that always evaluates
+  to ``False``. We do this to keep the code subject to refactorings and type
+  checkers. We use ``azul.false()`` instead of just the ``False`` literal, in
+  order to avoid the detection of unreachable code during static analysis by
+  PyCharm and CodeQL.
 
 Control flow
 ------------