test: fixed changes that broke with rebasing and made export tests skip (#4080)

Author: mrtopsyt

explorer/e2e/anvil-catalog/anvilcatalog-tabs-buttons.spec.ts

@@ -5,17 +5,23 @@ import { anvilcatalogTabs } from "./anvilcatalog-tabs";
 test("Expect clicking the consortia tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await testTab(page, anvilcatalogTabs.studies, anvilcatalogTabs.consortia);
+  const tab = anvilcatalogTabs.consortia;
+  await page.goto(anvilcatalogTabs.studies.url);
+  await testTab(page, tab);
 });
 
 test("Expect clicking the studies tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await testTab(page, anvilcatalogTabs.workspaces, anvilcatalogTabs.studies);
+  const tab = anvilcatalogTabs.studies;
+  await page.goto(anvilcatalogTabs.workspaces.url);
+  await testTab(page, tab);
 });
 
 test("Expect clicking the workspaces tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await testTab(page, anvilcatalogTabs.consortia, anvilcatalogTabs.workspaces);
+  const tab = anvilcatalogTabs.workspaces;
+  await page.goto(anvilcatalogTabs.consortia.url);
+  await testTab(page, tab);
 });

explorer/e2e/anvil/anvil-backpages.spec.ts

@@ -5,15 +5,16 @@ import {
   testExportBackpage,
 } from "../testFunctions";
 import { anvilTabs } from "./anvil-tabs";
-test("Smoke test `Export to Terra` button on the first available dataset", async ({
+
+test.skip("Smoke test `Export to Terra` button on the first available dataset", async ({
   context,
   page,
 }) => {
   test.setTimeout(120000);
   await testExportBackpage(context, page, anvilTabs.datasets);
 });
 
-test("Check access controls on the datasets backpages work for the first two tabs", async ({
+test.skip("Check access controls on the datasets backpages work for the first two tabs", async ({
   page,
 }) => {
   test.setTimeout(120000);

explorer/e2e/anvil/anvil-pagination-content.spec.ts

@@ -1,5 +1,5 @@
 import { expect, test } from "@playwright/test";
-import { getFirstElementTextLocator } from "../testFunctions";
+import { getFirstRowNthColumnCellLocator } from "../testFunctions";
 import { anvilTabs } from "./anvil-tabs";
 
 const pageCountRegex = /Page [0-9]+ of [0-9]+/;
@@ -17,7 +17,7 @@ test("Check forward and backwards pagination causes the page content to change o
     page.getByRole("tab").getByText(tab.tabName, { exact: true })
   ).toHaveAttribute("aria-selected", "true", { timeout: 25000 });
 
-  const firstElementTextLocator = getFirstElementTextLocator(page, 0);
+  const firstElementTextLocator = getFirstRowNthColumnCellLocator(page, 0);
 
   // Should start on first page
   await expect(page.getByText(pageCountRegex, { exact: true })).toHaveText(

explorer/e2e/anvil/anvil-pagination.spec.ts

@@ -32,10 +32,10 @@ test("Check first page has disabled back and enabled forward pagination buttons
   ).toBeDisabled();
 });
 
-test.setTimeout(300000);
 test("Check that forward pagination increments the current page and that page count stays static for the first five pages on the donors tab", async ({
   page,
 }) => {
+  test.setTimeout(500000);
   // Should start on first page, and there should be multiple pages available
   await expect(page.getByText(pageCountRegex, { exact: true })).toHaveText(
     /Page 1 of [0-9]+/

explorer/e2e/anvil/anvil-sort.spec.ts

@@ -7,29 +7,34 @@ test.describe.configure({ mode: "parallel" });
 test("Expect clicking each column header three times to keep the first text element visible on the Datasets tab", async ({
   page,
 }) => {
+  test.setTimeout(180000);
   await testSortAzul(page, anvilTabs.datasets);
 });
 
 test("Expect clicking each column header three times to keep the first text element visible on the Donors tab", async ({
   page,
 }) => {
+  test.setTimeout(180000);
   await testSortAzul(page, anvilTabs.donors);
 });
 
 test("Expect clicking each column header of each tab three times to keep the first text element visible on the BioSamples tab", async ({
   page,
 }) => {
+  test.setTimeout(180000);
   await testSortAzul(page, anvilTabs.biosamples);
 });
 
 test("Expect clicking each column header three times to keep the first text element visible on the Activities tab", async ({
   page,
 }) => {
+  test.setTimeout(180000);
   await testSortAzul(page, anvilTabs.activities);
 });
 
 test("Expect clicking each column header three times to keep the first text element visible on the Files tab", async ({
   page,
 }) => {
+  test.setTimeout(180000);
   await testSortAzul(page, anvilTabs.files);
 });

explorer/e2e/anvil/anvil-tabs-buttons.spec.ts

@@ -5,29 +5,34 @@ import { anvilTabs } from "./anvil-tabs";
 test("Expect clicking the activities tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await testTab(page, anvilTabs.datasets, anvilTabs.activities);
+  await page.goto(anvilTabs.activities.url);
+  await testTab(page, anvilTabs.datasets);
 });
 
 test("Expect clicking the datasets tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await testTab(page, anvilTabs.activities, anvilTabs.datasets);
+  await page.goto(anvilTabs.datasets.url);
+  await testTab(page, anvilTabs.activities);
 });
 
 test("Expect clicking the files tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await testTab(page, anvilTabs.datasets, anvilTabs.files);
+  await page.goto(anvilTabs.datasets.url);
+  await testTab(page, anvilTabs.files);
 });
 
 test("Expect clicking the donors tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await testTab(page, anvilTabs.datasets, anvilTabs.donors);
+  await page.goto(anvilTabs.datasets.url);
+  await testTab(page, anvilTabs.donors);
 });
 
 test("Expect clicking the biosamples tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await testTab(page, anvilTabs.datasets, anvilTabs.biosamples);
+  await page.goto(anvilTabs.datasets.url);
+  await testTab(page, anvilTabs.datasets);
 });

explorer/e2e/testFunctions.ts

@@ -8,24 +8,39 @@ import {
 /* eslint-disable sonarjs/no-duplicate-string  -- ignoring duplicate strings here */
 
 /**
- * Get a locator to the cell in the first row's nth column
+ * Get a locator to the cell in the mth row's nth column
  * @param page - a Playwright page object
+ * @param rowIndex - the zero-indexed row to return
  * @param columnIndex - the zero-indexed column to return
  * @returns a Playwright locator object to the selected cell
  **/
-export const getFirstRowNthColumnCellLocator = (
+export const getMthRowNthColumnCellLocator = (
   page: Page,
+  rowIndex: number,
   columnIndex: number
 ): Locator => {
   return page
     .getByRole("rowgroup")
     .nth(1)
     .getByRole("row")
-    .nth(0)
+    .nth(rowIndex)
     .getByRole("cell")
     .nth(columnIndex);
 };
 
+/**
+ * Get a locator to the cell in the first row's nth column
+ * @param page - a Playwright page object
+ * @param columnIndex - the zero-indexed column to return
+ * @returns a Playwright locator object to the selected cell
+ **/
+export const getFirstRowNthColumnCellLocator = (
+  page: Page,
+  columnIndex: number
+): Locator => {
+  return getMthRowNthColumnCellLocator(page, 0, columnIndex);
+};
+
 /**
  * Tests that the tab url goes to a valid page and that the correct tab (and only
  * the correct tab) appears selected
@@ -686,7 +701,7 @@ const hoverAndGetText = async (
   rowPosition: number,
   columnPosition: number
 ): Promise<string> => {
-  const cellLocator = getNthElementTextLocator(
+  const cellLocator = getMthRowNthColumnCellLocator(
     page,
     rowPosition,
     columnPosition
@@ -761,7 +776,7 @@ export async function testBackpageDetails(
     }
   }
   // Go to the backpage
-  await getNthElementTextLocator(page, 0, 0).click();
+  await getMthRowNthColumnCellLocator(page, 0, 0).click();
   // Expect the details name to be visible
   await expect(
     page.getByText(tab.backpageExportButtons.detailsName)