fix: refactored locators and cleaned up typos in tests (#4078)

Author: mrtopsyt

Diff for: explorer/e2e/anvil-catalog/anvilcatalog-tabs-buttons.spec.ts

@@ -5,23 +5,17 @@ import { anvilcatalogTabs } from "./anvilcatalog-tabs";
 test("Expect clicking the consortia tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  const tab = anvilcatalogTabs.consortia;
-  await page.goto(anvilcatalogTabs.studies.url);
-  await testTab(page, tab);
+  await testTab(page, anvilcatalogTabs.studies, anvilcatalogTabs.consortia);
 });
 
 test("Expect clicking the studies tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  const tab = anvilcatalogTabs.studies;
-  await page.goto(anvilcatalogTabs.workspaces.url);
-  await testTab(page, tab);
+  await testTab(page, anvilcatalogTabs.workspaces, anvilcatalogTabs.studies);
 });
 
 test("Expect clicking the workspaces tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  const tab = anvilcatalogTabs.workspaces;
-  await page.goto(anvilcatalogTabs.consortia.url);
-  await testTab(page, tab);
+  await testTab(page, anvilcatalogTabs.consortia, anvilcatalogTabs.workspaces);
 });

Diff for: explorer/e2e/anvil/anvil-tabs-buttons.spec.ts

@@ -2,37 +2,32 @@ import { test } from "@playwright/test";
 import { testTab } from "../testFunctions";
 import { anvilTabs } from "./anvil-tabs";
 
-test("Expect clicking the datasets tab to go to the correct url and to show all of the relevant columns when selected", async ({
+test("Expect clicking the activities tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await page.goto(anvilTabs.activities.url);
-  await testTab(page, anvilTabs.datasets);
+  await testTab(page, anvilTabs.datasets, anvilTabs.activities);
 });
 
-test("Expect clicking the activities tab to go to the correct url and to show all of the relevant columns when selected", async ({
+test("Expect clicking the datasets tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await page.goto(anvilTabs.datasets.url);
-  await testTab(page, anvilTabs.activities);
+  await testTab(page, anvilTabs.activities, anvilTabs.datasets);
 });
 
 test("Expect clicking the files tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await page.goto(anvilTabs.datasets.url);
-  await testTab(page, anvilTabs.files);
+  await testTab(page, anvilTabs.datasets, anvilTabs.files);
 });
 
 test("Expect clicking the donors tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await page.goto(anvilTabs.datasets.url);
-  await testTab(page, anvilTabs.donors);
+  await testTab(page, anvilTabs.datasets, anvilTabs.donors);
 });
 
 test("Expect clicking the biosamples tab to go to the correct url and to show all of the relevant columns when selected", async ({
   page,
 }) => {
-  await page.goto(anvilTabs.datasets.url);
-  await testTab(page, anvilTabs.biosamples);
+  await testTab(page, anvilTabs.datasets, anvilTabs.biosamples);
 });