Skip to content

Commit b9b21d5

Browse files
MillenniumFalconMechanicNoopDog
authored andcommitted
Added project shortname to filter. Resolves #1653.
1 parent 3e01802 commit b9b21d5

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

spa/src/app/files/_ngrx/files.effects.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,6 @@ export class FilesEffects {
248248
*/
249249
private isAnyProjectSelected(searchTermsByFacetName: Map<string, Set<SearchTerm>>): boolean {
250250

251-
return searchTermsByFacetName.has(FileFacetName.PROJECT) || searchTermsByFacetName.has(FileFacetName.PROJECT_ID);
251+
return searchTermsByFacetName.has(FileFacetName.PROJECT_ID);
252252
}
253253
}

spa/src/app/files/_ngrx/search/search.selectors.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ export const selectSelectedSearchTermsBySearchKey = createSelector(selectSearch,
3030
// Selected project search terms - returns the current set of selected projects
3131
export const selectSelectedProjectSearchTerms = createSelector(selectSearch, (state) => {
3232
return state.selectedSearchTerms.filter((searchTerm: SearchTerm) => {
33-
return searchTerm.getSearchKey() === FileFacetName.PROJECT ||
34-
searchTerm.getSearchKey() === FileFacetName.PROJECT_ID;
33+
return searchTerm.getSearchKey() === FileFacetName.PROJECT_ID;
3534
});
3635
});
3736

spa/src/app/files/entity/entity-request.service.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export class EntityRequestService {
109109
}
110110

111111
/**
112-
* Remove project facet and/or project IDs from list of search terms as we do not want to restrict the table result
112+
* Remove project ID facet from list of search terms as we do not want to restrict the table result
113113
* set to just the selected project.
114114
*
115115
* @param {Map<string, Set<SearchTerm>>} searchTermsByFacetName
@@ -120,7 +120,6 @@ export class EntityRequestService {
120120
searchTermsByFacetName: Map<string, Set<SearchTerm>>, selectedEntity: string): Map<string, Set<SearchTerm>> {
121121

122122
const filteredSearchTerms = new Map(searchTermsByFacetName);
123-
filteredSearchTerms.delete(FileFacetName.PROJECT);
124123
filteredSearchTerms.delete(FileFacetName.PROJECT_ID);
125124
return filteredSearchTerms;
126125
}

spa/src/app/files/facet/file-facet/file-facet-name-display.model.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
export enum FileFacetNameDisplay {
1010
"disease" = "Disease Status",
1111
"libraryConstructionApproach" = "Library Construction Method",
12+
"project" = "Project Label",
1213
"projectId" = "Project",
1314
"sampleEntityType" = "Sample Type",
1415
"specimenOrgan" = "Organ",

spa/src/app/files/search/http/search-term-http.service.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ describe("SearchTermHttpService:", () => {
4242
/**
4343
* Confirm project facet is not added as a search term.
4444
*/
45-
it("excludes project facet from search terms", () => {
45+
it("binds project facet in search terms", () => {
4646

4747
const searchTerms = searchTermHttpService.bindSearchTerms(PROJECTS_ENTITY_API_RESPONSE.termFacets);
4848
expect(searchTerms).toBeTruthy();
4949
const projectSearchTerm = searchTerms.find((searchTerm) => searchTerm.facetName === FileFacetName.PROJECT);
50-
expect(projectSearchTerm).toBeFalsy();
50+
expect(projectSearchTerm).toBeTruthy();
5151
});
5252

5353

spa/src/app/files/search/http/search-term-http.service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export class SearchTermHttpService {
4040
"organismAgeValue",
4141
"pairedEnd",
4242
"preservationMethod",
43+
"project",
4344
"projectTitle",
4445
"publicationTitle",
4546
"sampleDisease",

0 commit comments

Comments
 (0)