Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the general and dataset-details Export panes consistent #4102

Closed
mbaumann-broad opened this issue Aug 10, 2024 · 4 comments · Fixed by #4356
Closed

Make the general and dataset-details Export panes consistent #4102

mbaumann-broad opened this issue Aug 10, 2024 · 4 comments · Fixed by #4356
Assignees
Labels
canary Done by the Clever Canary team

Comments

@mbaumann-broad
Copy link

Discussed in Slack here.

Currently, File Manifest export is on the dataset-details Metadata pane.
Moving that to the Export pane is more consistent with the general export page.
image

(With ff=verabim enabled) the dataset-details Export pane would then look like the general export page:
image

@github-actions github-actions bot added the canary Done by the Clever Canary team label Aug 10, 2024
@frano-m frano-m assigned frano-m and NoopDog and unassigned frano-m Aug 12, 2024
@MillenniumFalconMechanic
Copy link
Contributor

See mocks (and UI background).

@NoopDog
Copy link
Collaborator

NoopDog commented Aug 27, 2024

Hi @frano-m, this is approved to develop!

@frano-m
Copy link
Contributor

frano-m commented Oct 30, 2024

To consider:

  • Handling of user log in and log out.
  • Loading states.

@frano-m frano-m assigned frano-m and unassigned frano-m Dec 10, 2024
@MillenniumFalconMechanic MillenniumFalconMechanic removed their assignment Feb 3, 2025
@NoopDog
Copy link
Collaborator

NoopDog commented Feb 3, 2025

@frano-m, this is on cc-dev. Can you take it for a spin and check if it looks ok? Thx. We especially want to be sure the verbatim PFB stuff is still ok and also the normal exports work as well. We want to ensure the number of requests and summaries are the same as on the main. Also, the exports create the same URLs to Azul. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants