[rum] Inject browser sdk #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
2 times, most recently
from
47ec98f to
73486c7
Compare
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
a305acd to
fceab29
Compare
yoannmoinet
changed the base branch from
yoann/move-sourcemaps
to
yoann/add-more-injection-points
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
fceab29 to
3c35484
Compare
yoannmoinet
force-pushed
the
yoann/add-more-injection-points
branch
from
84950be to
74d2575
Compare
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
2 times, most recently
from
e401db0 to
d66990f
Compare
yoannmoinet
changed the base branch from
yoann/add-more-injection-points
to
yoann/better-sandbox-tests
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
d66990f to
5f3ea86
Compare
yoannmoinet
changed the base branch from
yoann/better-sandbox-tests
to
yoann/lighten-readmes
Merged
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
5f3ea86 to
f158564
Compare
yoannmoinet
changed the base branch from
yoann/v2.5.0
to
yoann/add-e2e-testing
Ayc0
reviewed
Feb 12, 2025
Ayc0
reviewed
Feb 12, 2025
README.md
Outdated
| datadogWebpackPlugin({ | ||
| rum?: { | ||
| disabled?: boolean, | ||
| sdk?: { |
There was a problem hiding this comment.
Maybe we could use the RUM type directly here, no?
There was a problem hiding this comment.
That's a very good idea, I'll check if I can.
There was a problem hiding this comment.
I put that on the wrong file, oops, this is the README, not the source types
Ayc0
reviewed
Feb 12, 2025
packages/plugins/rum/README.md
Outdated
Comment on lines
14
to
16
| - [rum.sdk.applicationId](#rumsdkapplicationid) | ||
| - [rum.sdk.clientToken](#rumsdkclienttoken) | ||
| - [rum.sdk.site](#rumsdksite) |
There was a problem hiding this comment.
Similarly, maybe we don't need to document all of those. Instead we could reference the general doc in the public documentation website, WDYT?
There was a problem hiding this comment.
Makes sense, I'm afraid of getting out of sync, but I do prefer having a single source of truth.
There was a problem hiding this comment.
If you want only 1 source of truth, you'd need to add a dependency on @datadog/browser-rum instead of checking the global DD_RUM (right now you're only using a devDep)
Ayc0
reviewed
Feb 12, 2025
Comment on lines
+14
to
+16
| DD_RUM.addAction('custom_click', { | ||
| bundler: '{{bundler}}', | ||
| }); |
Ayc0
reviewed
Feb 12, 2025
|
|
||
| import { datadogRum } from '@datadog/browser-rum'; | ||
|
|
||
| // To please TypeScript. |
yoannmoinet
force-pushed
the
yoann/v2.5.0
branch
from
17e30b5 to
73662a4
Compare
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
2 times, most recently
from
68f129f to
378742a
Compare
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
378742a to
d8d6d43
Compare
Co-authored-by: Benjamin Koltes <[email protected]>
yoannmoinet
force-pushed
the
yoann/inject-browser-sdk
branch
from
d8d6d43 to
8784499
Compare
yoannmoinet
commented
Feb 27, 2025
Comment on lines
-126
to
-127
| - run: yarn typecheck:all | ||
|
|
There was a problem hiding this comment.
This is done part of the yarn cli integrity now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Automatically inject RUM's Browser SDK into the bundle.
How?
rum-browser-sdk.jswhich is used for the injection.TODO