[procmgr] Add GetMetrics gRPC RPC to dd-procmgrd by jose-manuel-almaza · Pull Request #51788 · DataDog/datadog-agent

jose-manuel-almaza · 2026-06-04T13:38:52Z

What does this PR do?

Adds a GetMetrics gRPC RPC to dd-procmgrd: clients pass a single name_or_uuid (same resolution rules as Describe) and receive a ProcessMetrics payload with supervision fields (name, uuid, pid, state, restart_count, optional last exit code / signal). Proto also defines optional rss_bytes and cpu_percent.

Motivation

Establishes a dedicated RPC for per-process telemetry and future resource stats without overloading List / Describe, and keeps COAT or other callers able to depend on a stable metrics-oriented contract.

Describe how you validated your changes

cargo test -p dd-procmgrd (includes new GetMetrics gRPC tests: empty name → InvalidArgument, known name → metrics, unknown name → NotFound).

Additional Notes

Expose per-process supervision fields (state, pid, restarts) with optional rss_bytes/cpu_percent reserved for future sampling. The request mirrors Describe (single name_or_uuid); empty input is rejected.

github-actions · 2026-06-04T13:39:03Z

@codex review

chatgpt-codex-connector · 2026-06-04T13:40:48Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

datadog-official · 2026-06-04T13:42:45Z

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/datadog-agent | oracle: [21.3.0-xe]

See error
Failed to ping oracle instance: ORA-12514: TNS:listener does not currently know of service requested in connect descriptor error occur at position: 0

DataDog/datadog-agent | unit_tests_notify

See error
Artifact file 'junit-tests_*.tgz' not found during execution.

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 43bbbb1 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-06-04T14:10:21Z

Files inventory check summary

File checks results against ancestor 9464d1fa:

Results for datadog-agent_7.81.0~devel.git.507.43bbbb1.pipeline.117258563-1_amd64.deb:

No change detected

dd-octo-sts · 2026-06-04T14:18:50Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 9464d1f
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+11.14 KiB (0.00% increase, -0.20% of buffer)	745.449 → 745.460 → 750.810
✅	agent_deb_amd64_fips	+11.14 KiB (0.00% increase, -1.20% of buffer)	703.396 → 703.406 → 704.300
✅	agent_rpm_amd64	+11.14 KiB (0.00% increase, -0.20% of buffer)	745.433 → 745.444 → 750.780
✅	agent_rpm_amd64_fips	+11.14 KiB (0.00% increase, -1.18% of buffer)	703.379 → 703.390 → 704.300
✅	agent_rpm_arm64	+12.57 KiB (0.00% increase, -0.83% of buffer)	723.010 → 723.022 → 724.490
✅	agent_rpm_arm64_fips	+12.57 KiB (0.00% increase, -1.51% of buffer)	684.059 → 684.071 → 684.870
✅	agent_suse_amd64	+11.14 KiB (0.00% increase, -0.20% of buffer)	745.433 → 745.444 → 750.780
✅	agent_suse_amd64_fips	+11.14 KiB (0.00% increase, -1.18% of buffer)	703.379 → 703.390 → 704.300
✅	agent_suse_arm64	+12.57 KiB (0.00% increase, -0.83% of buffer)	723.010 → 723.022 → 724.490
✅	agent_suse_arm64_fips	+12.57 KiB (0.00% increase, -1.51% of buffer)	684.059 → 684.071 → 684.870
✅	docker_agent_amd64	+11.14 KiB (0.00% increase, -0.78% of buffer)	805.460 → 805.471 → 806.850
✅	docker_agent_arm64	+12.57 KiB (0.00% increase, -0.55% of buffer)	807.862 → 807.874 → 810.110
✅	docker_agent_jmx_amd64	+11.13 KiB (0.00% increase, -0.90% of buffer)	996.401 → 996.412 → 997.610
✅	docker_agent_jmx_arm64	+12.57 KiB (0.00% increase, -0.53% of buffer)	987.455 → 987.467 → 989.790

18 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_heroku_amd64	311.057 MiB
✅	docker_cluster_agent_amd64	207.435 MiB
✅	docker_cluster_agent_arm64	221.396 MiB
✅	docker_cws_instrumentation_amd64	7.154 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.472 MiB
✅	docker_dogstatsd_arm64	37.690 MiB
✅	docker_host_profiler_amd64	302.835 MiB
✅	docker_host_profiler_arm64	314.291 MiB
✅	dogstatsd_deb_amd64	30.129 MiB
✅	dogstatsd_deb_arm64	28.247 MiB
✅	dogstatsd_rpm_amd64	30.129 MiB
✅	dogstatsd_suse_amd64	30.129 MiB
✅	iot_agent_deb_amd64	45.000 MiB
✅	iot_agent_deb_arm64	41.929 MiB
✅	iot_agent_deb_armhf	42.652 MiB
✅	iot_agent_rpm_amd64	45.000 MiB
✅	iot_agent_suse_amd64	44.999 MiB

cit-pr-commenter-54b7da · 2026-06-04T14:29:39Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 741316ba-57dd-41c6-ae14-d66cba70a363

Baseline: 9464d1f
Comparison: 43bbbb1
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-2.95	[-5.91, +0.02]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.65	[+0.62, +2.68]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.61	[+0.45, +0.76]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.29	[+0.24, +0.34]	1	Logs
➖	docker_containers_memory	memory utilization	+0.24	[+0.14, +0.34]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.23	[+0.20, +0.27]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.19	[-0.04, +0.43]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.17	[-0.02, +0.35]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.04	[-0.12, +0.19]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.02	[-0.40, +0.44]	1	Logs
➖	ddot_metrics	memory utilization	+0.01	[-0.19, +0.21]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.10, +0.11]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.00	[-0.20, +0.20]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.52, +0.51]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.14, +0.13]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.21, +0.20]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.04	[-0.48, +0.39]	1	Logs
➖	ddot_logs	memory utilization	-0.10	[-0.16, -0.04]	1	Logs
➖	file_tree	memory utilization	-0.12	[-0.17, -0.07]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.16	[-0.41, +0.10]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	-0.17	[-0.27, -0.08]	1	Logs
➖	quality_gate_idle	memory utilization	-0.26	[-0.31, -0.21]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-1.84	[-2.04, -1.65]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-2.95	[-5.91, +0.02]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	714 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	248.22MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	546 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	145.88MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	732.31KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	475.32MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	176.67MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.34MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	353.52 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	391.47MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.93GiB ≤ 1.04GiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
ddot_logs	baseline	10	Oom killed	Debug Dashboard
ddot_logs	comparison	10	Oom killed	Debug Dashboard
ddot_metrics	baseline	10	Oom killed	Debug Dashboard
ddot_metrics	comparison	10	Oom killed	Debug Dashboard
ddot_metrics_sum_cumulative	baseline	10	Oom killed	Debug Dashboard
ddot_metrics_sum_cumulative	comparison	10	Oom killed	Debug Dashboard
ddot_metrics_sum_cumulativetodelta_exporter	baseline	10	Oom killed	Debug Dashboard
ddot_metrics_sum_cumulativetodelta_exporter	comparison	10	Oom killed	Debug Dashboard
ddot_metrics_sum_delta	baseline	10	Oom killed	Debug Dashboard
ddot_metrics_sum_delta	comparison	10	Oom killed	Debug Dashboard
docker_containers_cpu	baseline	10	Oom killed	Debug Dashboard
docker_containers_cpu	comparison	10	Oom killed	Debug Dashboard
docker_containers_memory	baseline	10	Oom killed	Debug Dashboard
docker_containers_memory	comparison	10	Oom killed	Debug Dashboard
file_to_blackhole_0ms_latency	baseline	10	Oom killed	Debug Dashboard
file_to_blackhole_0ms_latency	comparison	10	Oom killed	Debug Dashboard
file_to_blackhole_1000ms_latency	baseline	10	Oom killed	Debug Dashboard
file_to_blackhole_1000ms_latency	comparison	10	Oom killed	Debug Dashboard
file_to_blackhole_100ms_latency	baseline	10	Oom killed	Debug Dashboard
file_to_blackhole_100ms_latency	comparison	10	Oom killed	Debug Dashboard
file_to_blackhole_500ms_latency	baseline	10	Oom killed	Debug Dashboard
file_to_blackhole_500ms_latency	comparison	10	Oom killed	Debug Dashboard
file_tree	baseline	10	Oom killed	Debug Dashboard
file_tree	comparison	10	Oom killed	Debug Dashboard
otlp_ingest_logs	baseline	10	Oom killed	Debug Dashboard
otlp_ingest_logs	comparison	10	Oom killed	Debug Dashboard
otlp_ingest_metrics	baseline	10	Oom killed	Debug Dashboard
otlp_ingest_metrics	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
tcp_dd_logs_filter_exclude	baseline	10	Oom killed	Debug Dashboard
tcp_dd_logs_filter_exclude	comparison	10	Oom killed	Debug Dashboard
tcp_syslog_to_blackhole	baseline	10	Oom killed	Debug Dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders	baseline	10	Oom killed	Debug Dashboard
uds_dogstatsd_to_api	baseline	10	Oom killed	Debug Dashboard
uds_dogstatsd_to_api	comparison	10	Oom killed	Debug Dashboard
uds_dogstatsd_to_api_v3	baseline	10	Oom killed	Debug Dashboard
uds_dogstatsd_to_api_v3	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Clippy rejects `.err().expect()` on Result; `expect_err` preserves the same assertion.

github-actions · 2026-06-05T08:07:28Z

@codex review

chatgpt-codex-connector · 2026-06-05T08:09:37Z

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Add GetMetrics gRPC RPC to dd-procmgrd

85762af

Expose per-process supervision fields (state, pid, restarts) with optional rss_bytes/cpu_percent reserved for future sampling. The request mirrors Describe (single name_or_uuid); empty input is rejected.

dd-octo-sts Bot added internal Identify a non-fork PR team/agent-runtimes labels Jun 4, 2026

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jun 4, 2026

jose-manuel-almaza added qa/done QA done before merge and regressions are covered by tests and removed short review PR is simple enough to be reviewed quickly team/agent-runtimes internal Identify a non-fork PR labels Jun 4, 2026

jose-manuel-almaza added the changelog/no-changelog No changelog entry needed label Jun 4, 2026

fix(procmgr): use expect_err in GetMetrics invalid-name test

43bbbb1

Clippy rejects `.err().expect()` on Result; `expect_err` preserves the same assertion.

dd-octo-sts Bot added internal Identify a non-fork PR team/agent-runtimes labels Jun 5, 2026

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jun 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[procmgr] Add GetMetrics gRPC RPC to dd-procmgrd#51788

[procmgr] Add GetMetrics gRPC RPC to dd-procmgrd#51788
jose-manuel-almaza wants to merge 2 commits into
mainfrom
jose/procmgr-get-metrics

jose-manuel-almaza commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 4, 2026

Uh oh!

datadog-official Bot commented Jun 4, 2026 •

edited by datadog-datadog-prod-us1 Bot

Loading

Uh oh!

dd-octo-sts Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented Jun 4, 2026 •

edited

Loading

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Jun 4, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Replicate Execution Details

❌ Retried Profiling Replicate Execution Failures (ddprof)

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jose-manuel-almaza commented Jun 4, 2026

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 4, 2026

Uh oh!

datadog-official Bot commented Jun 4, 2026 • edited by datadog-datadog-prod-us1 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

Uh oh!

dd-octo-sts Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.81.0~devel.git.507.43bbbb1.pipeline.117258563-1_amd64.deb:

Uh oh!

dd-octo-sts Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Replicate Execution Details

❌ Retried Profiling Replicate Execution Failures (ddprof)

CI Pass/Fail Decision

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

datadog-official Bot commented Jun 4, 2026 •

edited by datadog-datadog-prod-us1 Bot

Loading

dd-octo-sts Bot commented Jun 4, 2026 •

edited

Loading

dd-octo-sts Bot commented Jun 4, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Jun 4, 2026 •

edited

Loading