Skip to content

Commit 0f8251a

Browse files
committed
address PR comments
1 parent bf75401 commit 0f8251a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/origin/CodeOriginTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ private static void checkEntrySpanTags(MutableSpan span, boolean includeSnapshot
196196
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "file"));
197197
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "line"));
198198
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "method"));
199+
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "signature"));
199200
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "type"));
200201

201202
if (includeSnapshot) {
@@ -224,7 +225,7 @@ private static void checkExitSpanTags(MutableSpan span, boolean includeSnapshot)
224225
format("Existing keys for %s: %s", span.getOperationName(), new TreeSet<>(ldKeys(span)));
225226

226227
assertKeyPresent(span, DD_STACK_CODE_ORIGIN_TYPE);
227-
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 3, "file"));
228+
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "file"));
228229
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "line"));
229230
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "method"));
230231
assertKeyPresent(span, format(DD_STACK_CODE_ORIGIN_FRAME, 0, "type"));

dd-trace-api/src/main/java/datadog/trace/api/DDTags.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ public class DDTags {
66
public static final String DD_STACK_CODE_ORIGIN_PREFIX = DD_LD_PREFIX + "code_origin.";
77

88
public static final String DD_STACK_CODE_ORIGIN_TYPE = DD_STACK_CODE_ORIGIN_PREFIX + "type";
9-
// _dd.stack.code_origin.frame.%d.file|line|method|type|snapshot_id
9+
// _dd.ld.code_origin.frames.%d.file|line|method|type|snapshot_id
1010
public static final String DD_STACK_CODE_ORIGIN_FRAME =
1111
DD_STACK_CODE_ORIGIN_PREFIX + "frames.%d.%s";
1212

0 commit comments

Comments
 (0)