Skip to content

Commit 5c54fec

Browse files
committed
do the "orDefault" as well
1 parent 3efcbc9 commit 5c54fec

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

internal-api/src/main/java/datadog/trace/api/Config.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
537537
this.instrumenterConfig = instrumenterConfig;
538538
configFileStatus = configProvider.getConfigFileStatus();
539539
runtimeIdEnabled = configProvider.getBoolean(RUNTIME_ID_ENABLED, true);
540-
runtimeVersion = System.getProperty("java.version", "unknown");
540+
runtimeVersion = SystemUtils.getPropertyOrDefault("java.version", "unknown");
541541

542542
// Note: We do not want APiKey to be loaded from property for security reasons
543543
// Note: we do not use defined default here
@@ -3941,7 +3941,7 @@ private static String getProp(String name) {
39413941
}
39423942

39433943
private static String getProp(String name, String def) {
3944-
String value = System.getProperty(name, def);
3944+
String value = SystemUtils.getPropertyOrDefault(name, def);
39453945
if (value != null) {
39463946
ConfigCollector.get().put(name, value, ConfigOrigin.JVM_PROP);
39473947
}

internal-api/src/main/java/datadog/trace/util/SystemUtils.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,12 @@ public static String getEnvOrDefault(String envVar, String defaultValue) {
2626
}
2727

2828
public static String tryGetProperty(String property) {
29-
return getPropertyOrDefault(property, null);
29+
try {
30+
return System.getProperty(property);
31+
} catch (SecurityException e) {
32+
log.warn(logMessageOnSecurityError, "system property", property, e);
33+
return null;
34+
}
3035
}
3136

3237
public static String getPropertyOrDefault(String property, String defaultValue) {

0 commit comments

Comments
 (0)