Skip to content

Commit 696d319

Browse files
committed
feat(core): Move noopSpan() to AgentSpan rather than AgentTracer
The goal is to normalize the API
1 parent 70dd70b commit 696d319

File tree

42 files changed

+79
-71
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+79
-71
lines changed

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/api/Java8BytecodeBridge.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,19 @@
88
* were not supported prior to Java 8 and will lead to a class verification error.
99
*/
1010
public class Java8BytecodeBridge {
11-
/** @see AgentScope#noop() */
12-
public static AgentScope noopScope() {
13-
return AgentScope.noop();
11+
/** @see AgentSpan#noopSpan() */
12+
public static AgentSpan noopSpan() {
13+
return AgentSpan.noopSpan();
1414
}
1515

16-
/** @see AgentSpanContext#noop() */
16+
/** @see AgentSpanContext#noopSpanContext() */
1717
public static AgentSpanContext noopSpanContext() {
18-
return AgentSpanContext.noop();
18+
return AgentSpanContext.noopSpanContext();
1919
}
2020

21-
/** @see AgentTracer#noopSpan() */
22-
public static AgentSpan noopSpan() {
23-
return AgentTracer.noopSpan();
21+
/** @see AgentScope#noopScope() */
22+
public static AgentScope noopScope() {
23+
return AgentScope.noopScope();
2424
}
2525

2626
/** @see AgentTracer#blackholeSpan() */

dd-java-agent/instrumentation/akka-concurrent/src/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaActorCellInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
55
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activeScope;
66
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activeSpan;
7-
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.noopSpan;
7+
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.noopSpan;
88
import static java.util.Collections.singletonMap;
99
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
1010

dd-java-agent/instrumentation/akka-concurrent/src/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaMailboxInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
55
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activeScope;
66
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activeSpan;
7-
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.noopSpan;
7+
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.noopSpan;
88
import static java.util.Collections.singletonList;
99
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
1010

dd-java-agent/instrumentation/akka-http/akka-http-10.0/src/main/java/datadog/trace/instrumentation/akkahttp/AkkaPoolMasterActorInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package datadog.trace.instrumentation.akkahttp;
22

33
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
4+
import static datadog.trace.bootstrap.instrumentation.api.AgentSpan.noopSpan;
45
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
5-
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.noopSpan;
66

77
import com.google.auto.service.AutoService;
88
import datadog.trace.agent.tooling.Instrumenter;

dd-java-agent/instrumentation/akka-init/src/main/java/datadog/trace/instrumentation/akka/init/DisableTracingActorInitInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package datadog.trace.instrumentation.akka.init;
22

33
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
4+
import static datadog.trace.bootstrap.instrumentation.api.AgentSpan.noopSpan;
45
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
5-
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.noopSpan;
66

77
import akka.actor.ActorSystem$;
88
import com.google.auto.service.AutoService;

dd-java-agent/instrumentation/aws-java-sdk-2.2/src/main/java/datadog/trace/instrumentation/aws/v2/AwsHttpClientInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.nameStartsWith;
55
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
66
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.namedOneOf;
7+
import static datadog.trace.bootstrap.instrumentation.api.AgentSpan.noopSpan;
78
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
89
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activeScope;
9-
import static datadog.trace.bootstrap.instrumentation.api.Java8BytecodeBridge.noopSpan;
1010
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
1111
import static net.bytebuddy.matcher.ElementMatchers.isPublic;
1212
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;

dd-java-agent/instrumentation/caffeine/src/main/java/datadog/trace/instrumentation/caffeine/BoundedLocalCacheAdvice.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package datadog.trace.instrumentation.caffeine;
22

3+
import static datadog.trace.bootstrap.instrumentation.api.AgentSpan.noopSpan;
34
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
4-
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.noopSpan;
55

66
import datadog.trace.bootstrap.instrumentation.api.AgentScope;
77
import net.bytebuddy.asm.Advice;

dd-java-agent/instrumentation/caffeine/src/main/java/datadog/trace/instrumentation/caffeine/BoundedLocalCacheInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package datadog.trace.instrumentation.caffeine;
22

33
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
4+
import static datadog.trace.bootstrap.instrumentation.api.AgentSpan.noopSpan;
45
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
5-
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.noopSpan;
66
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
77

88
import com.google.auto.service.AutoService;

dd-java-agent/instrumentation/elasticsearch/transport/src/main/java/datadog/trace/instrumentation/elasticsearch/ShadowExistingScopeAdvice.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package datadog.trace.instrumentation.elasticsearch;
22

3+
import static datadog.trace.bootstrap.instrumentation.api.AgentSpan.noopSpan;
34
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
4-
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.noopSpan;
55

66
import datadog.trace.bootstrap.instrumentation.api.AgentScope;
77
import net.bytebuddy.asm.Advice;

dd-java-agent/instrumentation/jetty-client/jetty-client-12.0/src/main/java17/datadog/trace/instrumentation/jetty_client12/CallbackWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package datadog.trace.instrumentation.jetty_client12;
22

3+
import static datadog.trace.bootstrap.instrumentation.api.AgentSpan.noopSpan;
34
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
4-
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.noopSpan;
55

66
import datadog.trace.bootstrap.instrumentation.api.AgentScope;
77
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;

0 commit comments

Comments
 (0)