Skip to content

Commit cd5aa9e

Browse files
committed
cleanup
1 parent 3532a7a commit cd5aa9e

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

dd-trace-core/src/test/groovy/datadog/trace/core/propagation/BaggageHttpInjectorTest.groovy

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@ package datadog.trace.core.propagation
22

33
import datadog.trace.api.DDSpanId
44
import datadog.trace.api.DDTraceId
5+
import datadog.trace.api.DynamicConfig
56
import datadog.trace.bootstrap.instrumentation.api.AgentTracer.NoopPathwayContext
67
import datadog.trace.common.writer.ListWriter
8+
import datadog.trace.core.CoreTracer
79
import datadog.trace.core.DDSpanContext
810
import datadog.trace.core.test.DDCoreSpecification
911

@@ -14,12 +16,19 @@ import static datadog.trace.core.propagation.BaggageHttpCodec.*
1416

1517
class BaggageHttpInjectorTest extends DDCoreSpecification {
1618

17-
HttpCodec.Injector injector = newInjector(["some-baggage-key":"SOME_CUSTOM_HEADER"])
19+
private HttpCodec.Injector injector = newInjector(["some-baggage-key":"SOME_CUSTOM_HEADER"])
20+
private ListWriter writer
21+
private CoreTracer tracer
22+
private Map<String, String> carrier
23+
24+
void setup() {
25+
writer = new ListWriter()
26+
tracer = tracerBuilder().writer(writer).build()
27+
carrier = Mock()
28+
}
1829

1930
def "test baggage injection and encoding"() {
2031
setup:
21-
def writer = new ListWriter()
22-
def tracer = tracerBuilder().writer(writer).build()
2332
final DDSpanContext mockedContext =
2433
new DDSpanContext(
2534
DDTraceId.from("1"),
@@ -41,9 +50,6 @@ class BaggageHttpInjectorTest extends DDCoreSpecification {
4150
NoopPathwayContext.INSTANCE,
4251
false,
4352
PropagationTags.factory().fromHeaderValue(PropagationTags.HeaderType.DATADOG, "_dd.p.dm=-4,_dd.p.anytag=value"))
44-
45-
final Map<String, String> carrier = Mock()
46-
4753
when:
4854
injector.inject(mockedContext, carrier, MapSetter.INSTANCE)
4955

@@ -68,8 +74,6 @@ class BaggageHttpInjectorTest extends DDCoreSpecification {
6874
def "test baggage item limit"() {
6975
setup:
7076
injectSysConfig("trace.baggage.max.items", '2')
71-
def writer = new ListWriter()
72-
def tracer = tracerBuilder().writer(writer).build()
7377
final DDSpanContext mockedContext =
7478
new DDSpanContext(
7579
DDTraceId.from("1"),
@@ -92,8 +96,6 @@ class BaggageHttpInjectorTest extends DDCoreSpecification {
9296
false,
9397
PropagationTags.factory().fromHeaderValue(PropagationTags.HeaderType.DATADOG, "_dd.p.dm=-4,_dd.p.anytag=value"))
9498

95-
final Map<String, String> carrier = Mock()
96-
9799
when:
98100
injector.inject(mockedContext, carrier, MapSetter.INSTANCE)
99101

@@ -113,8 +115,6 @@ class BaggageHttpInjectorTest extends DDCoreSpecification {
113115
def "test baggage bytes limit"() {
114116
setup:
115117
injectSysConfig("trace.baggage.max.bytes", '20')
116-
def writer = new ListWriter()
117-
def tracer = tracerBuilder().writer(writer).build()
118118
final DDSpanContext mockedContext =
119119
new DDSpanContext(
120120
DDTraceId.from("1"),
@@ -137,8 +137,6 @@ class BaggageHttpInjectorTest extends DDCoreSpecification {
137137
false,
138138
PropagationTags.factory().fromHeaderValue(PropagationTags.HeaderType.DATADOG, "_dd.p.dm=-4,_dd.p.anytag=value"))
139139

140-
final Map<String, String> carrier = Mock()
141-
142140
when:
143141
injector.inject(mockedContext, carrier, MapSetter.INSTANCE)
144142

0 commit comments

Comments
 (0)