move logging of errors to end of agent.start

Author: vandonr

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java

@@ -41,6 +41,7 @@
 import datadog.trace.bootstrap.instrumentation.jfr.InstrumentationBasedProfiling;
 import datadog.trace.util.AgentTaskScheduler;
 import datadog.trace.util.AgentThreadFactory.AgentThread;
+import datadog.trace.util.SystemUtils;
 import datadog.trace.util.throwable.FatalAgentMisconfigurationError;
 import java.lang.instrument.Instrumentation;
 import java.lang.reflect.InvocationTargetException;
@@ -370,6 +371,18 @@ public void run() {
       StaticEventLogger.end("Profiling");
     }
 
+    // log eventual errors that would have happened before we could log them
+    if (SystemUtils.hasEnvError) {
+      log.warn(
+          "The Java Security Manager prevented the Datadog Tracer from accessing at least one environment variable. "
+              + "Consider granting AllPermission to the dd-java-agent jar.");
+    }
+    if (SystemUtils.hasPropertyError) {
+      log.warn(
+          "The Java Security Manager prevented the Datadog Tracer from accessing at least one system property. "
+              + "Consider granting AllPermission to the dd-java-agent jar.");
+    }
+
     StaticEventLogger.end("Agent.start");
   }
 

internal-api/src/main/java/datadog/trace/api/Config.java

@@ -4025,24 +4025,7 @@ private static String getProp(String name, String def) {
               : ConfigProvider.getInstance(),
           InstrumenterConfig.get());
 
-  private static boolean configErrorsLogged = false;
-
   public static Config get() {
-    // checking if there are errors that we couldn't log earlier to report
-    if (!configErrorsLogged && (SystemUtils.hasEnvError || SystemUtils.hasPropertyError)) {
-      // we want to log once, but if 2 threads end up here it's not a big issue.
-      configErrorsLogged = true;
-      if (SystemUtils.hasEnvError) {
-        log.warn(
-            "The Java Security Manager prevented the Datadog Tracer from accessing at least one environment variable. "
-                + "Consider granting AllPermission to the dd-java-agent jar.");
-      }
-      if (SystemUtils.hasPropertyError) {
-        log.warn(
-            "The Java Security Manager prevented the Datadog Tracer from accessing at least one system property. "
-                + "Consider granting AllPermission to the dd-java-agent jar.");
-      }
-    }
     return INSTANCE;
   }