Add path_params to symfony 5.2

Author: estringana

src/Integrations/Integrations/Symfony/SymfonyIntegration.php

@@ -401,6 +401,13 @@ function (SpanData $span, $args, $response) use ($integration) {
                     $rootSpan->meta[Tag::HTTP_STATUS_CODE] = $response->getStatusCode();
                 }
 
+                $parameters = $request->get('_route_params');
+                if (!empty($parameters) &&
+                    is_array($parameters) &&
+                    function_exists('\datadog\appsec\ddappsec_push_address')) {
+                    \datadog\appsec\ddappsec_push_address($parameters);
+                }
+
                 $route = $request->get('_route');
                 if (null !== $route && null !== $request) {
                     if (dd_trace_env_config("DD_HTTP_SERVER_ROUTE_BASED_NAMING")) {

tests/Frameworks/Symfony/Version_5_2/src/Controller/CommonScenariosController.php

@@ -32,6 +32,16 @@ public function simpleViewAction(Request $request)
         ]);
     }
 
+    /**
+     * @Route("/dynamic_route/{param01}/{param02?}", name="dynamic route with optionals")
+     */
+    public function dynamicWithOptionalsAction($param01, $param02)
+    {
+        return new Response(
+                   'Hi!'
+               );
+    }
+
     /**
      * @Route("/error", name="error")
      * @throws \Exception

tests/Integrations/Symfony/V5_2/PathParamsTest.php

@@ -0,0 +1,70 @@
+<?php
+
+namespace DDTrace\Tests\Integrations\Symfony\V5_2;
+
+use DDTrace\Tests\Common\WebFrameworkTestCase;
+use DDTrace\Tests\Frameworks\Util\Request\PostSpec;
+use DDTrace\Tests\Frameworks\Util\Request\GetSpec;
+use datadog\appsec\AppsecStatus;
+
+class PathParamsTest extends WebFrameworkTestCase
+{
+    protected static function getAppIndexScript()
+    {
+        return __DIR__ . '/../../../Frameworks/Symfony/Version_5_2/public/index.php';
+    }
+
+    protected function connection()
+    {
+        return new \PDO('mysql:host=mysql_integration;dbname=test', 'test', 'test');
+    }
+
+    protected function ddSetUp()
+    {
+        parent::ddSetUp();
+        AppsecStatus::getInstance()->setDefaults();
+    }
+
+    public static function ddSetUpBeforeClass()
+    {
+        parent::ddSetUpBeforeClass();
+        AppsecStatus::getInstance()->init();
+    }
+
+    public static function ddTearDownAfterClass()
+    {
+        AppsecStatus::getInstance()->destroy();
+        parent::ddTearDownAfterClass();
+    }
+
+    public function testDynamicRouteWithOptionalsFilled()
+    {
+        $param01 = 'first_param';
+        $param02 = 'second_param';
+        $this->call(GetSpec::create('dynamic', "/dynamic_route/$param01/$param02"));
+        $events = AppsecStatus::getInstance()->getEvents();
+        $this->assertEquals(1, count($events));
+        $this->assertEquals($param01, $events[0]['param01']);
+        $this->assertEquals($param02, $events[0]['param02']);
+        $this->assertEquals('ddappsec_push_address', $events[0]['eventName']);
+    }
+
+    public function testDynamicRouteWithOptionalsNotFilled()
+    {
+        $param01 = 'first_param';
+        $this->call(GetSpec::create('dynamic', "/dynamic_route/$param01"));
+        $events = AppsecStatus::getInstance()->getEvents();
+        $this->assertEquals(1, count($events));
+        $this->assertEquals($param01, $events[0]['param01']);
+        $this->assertEmpty($events[0]['param02']);
+        $this->assertEquals('ddappsec_push_address', $events[0]['eventName']);
+    }
+
+
+    public function testStaticRoute()
+    {
+        $this->call(GetSpec::create('static', "/simple"));
+        $events = AppsecStatus::getInstance()->getEvents();
+        $this->assertEquals(0, count($events));
+    }
+}