From 1b6cbc31c175a4713c0fcce3cf213f7e3967c98f Mon Sep 17 00:00:00 2001 From: Levi Morrison Date: Mon, 20 Nov 2023 11:10:03 -0700 Subject: [PATCH] [ci skip] elaborate on PHP 8.4 todo --- profiling/src/php_ffi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/profiling/src/php_ffi.c b/profiling/src/php_ffi.c index c7647221f0..450c1425b0 100644 --- a/profiling/src/php_ffi.c +++ b/profiling/src/php_ffi.c @@ -124,7 +124,7 @@ static void ddog_php_prof_install_opcode_handlers(uint32_t php_version_id) { zend_set_user_opcode_handler(ZEND_BIND_STATIC, dispatch_handler); } #if PHP_VERSION_ID >= 80400 -#error Check if ZEND_BIND_STATIC needs an opcode handler still. +#error Check if ZEND_BIND_STATIC needs an opcode handler still. Possibly update things like CFG_NEED_OPCODE_HANDLERS as well. #endif } #endif