Use valgrind suppressions instead of disabling valgrind (#2708)

Signed-off-by: Bob Weinand <[email protected]>

Author: bwoebi

Makefile

@@ -154,14 +154,14 @@ test_with_init_hook: $(SO_FILE) $(INIT_HOOK_TEST_FILES)
 test_extension_ci: $(SO_FILE) $(TEST_FILES) $(TEST_STUB_FILES)
 	( \
 	set -xe; \
+	export PATH="$(PROJECT_ROOT)/tests/ext/valgrind:$$PATH"; \
 	export DD_TRACE_CLI_ENABLED=1; \
 	export TEST_PHP_JUNIT=$(JUNIT_RESULTS_DIR)/normal-extension-test.xml; \
 	$(MAKE) -C $(BUILD_DIR) CFLAGS="-g" clean all; \
 	$(RUN_TESTS_CMD) -d extension=$(SO_FILE) $(BUILD_DIR)/$(TESTS); \
 	\
 	export TEST_PHP_JUNIT=$(JUNIT_RESULTS_DIR)/valgrind-extension-test.xml; \
 	export TEST_PHP_OUTPUT=$(JUNIT_RESULTS_DIR)/valgrind-run-tests.out; \
-	export DD_TRACE_SIDECAR_TRACE_SENDER=0; \
 	$(RUN_TESTS_CMD) -d extension=$(SO_FILE) -m -s $$TEST_PHP_OUTPUT $(BUILD_DIR)/$(TESTS) && ! grep -e 'LEAKED TEST SUMMARY' $$TEST_PHP_OUTPUT; \
 	)
 

tests/ext/background-sender/agent_sampling_sidecar.phpt

@@ -2,7 +2,6 @@
 The sidecar trace flusher sender informs about changes to the agent sample rate
 --SKIPIF--
 <?php include __DIR__ . '/../includes/skipif_no_dev_env.inc'; ?>
-<?php if ((getenv('USE_ZEND_ALLOC') === '0' && !getenv("SKIP_ASAN")) || getenv("TEST_PHP_JUNIT")) die('skip: valgrind reports sendmsg(msg.msg_control) points to uninitialised byte(s), but it is unproblematic and outside our control in rust code'); ?>
 --ENV--
 DD_TRACE_LOG_LEVEL=info,startup=off
 DD_AGENT_HOST=request-replayer

tests/ext/valgrind/suppressions.txt

@@ -0,0 +1,7 @@
+{
+   <sendmsg in rust has unitialized bytes>
+   Memcheck:Param
+   sendmsg(msg.msg_control)
+   fun:sendmsg
+   fun:*send_with_fd*
+}

tests/ext/valgrind/valgrind

@@ -0,0 +1,4 @@
+#!/bin/bash
+DIR=$(dirname "$0")
+export PATH=${PATH/${DIR//\//\\\/}:/}
+exec valgrind "--suppressions=$DIR/suppressions.txt" "$@"