Remove duplicated tag

Author: estringana

appsec/src/extension/ddappsec.c

@@ -116,7 +116,7 @@ static zend_extension ddappsec_extension_entry = {
 
 ZEND_GET_MODULE(ddappsec)
 
-#define DD_TAG_SERVER_REQUEST_PATH_PARAMS "server.request.path_params"
+#define DD_ADDRESS_SERVER_REQUEST_PATH_PARAMS "server.request.path_params"
 static zend_string *_key_server_request_path_params;
 
 // NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
@@ -224,7 +224,7 @@ static PHP_MINIT_FUNCTION(ddappsec)
     dd_request_shutdown_startup();
 
     _key_server_request_path_params = zend_string_init_interned(
-        LSTRARG(DD_TAG_SERVER_REQUEST_PATH_PARAMS), 1);
+        LSTRARG(DD_ADDRESS_SERVER_REQUEST_PATH_PARAMS), 1);
 
     return SUCCESS;
 }

appsec/src/extension/tags.c

@@ -4,11 +4,9 @@
 // This product includes software developed at Datadog
 // (https://www.datadoghq.com/). Copyright 2021 Datadog, Inc.
 #include "tags.h"
-#include "commands/request_exec.h"
 #include "ddappsec.h"
 #include "ddtrace.h"
 #include "ext/pcre/php_pcre.h"
-#include "helper_process.h"
 #include "ip_extraction.h"
 #include "logging.h"
 #include "php_compat.h"
@@ -42,7 +40,6 @@
 #define DD_TAG_HTTP_RH_CONTENT_LANGUAGE "http.response.headers.content-language"
 #define DD_TAG_HTTP_CLIENT_IP "http.client_ip"
 #define DD_TAG_USER_ID "usr.id"
-#define DD_TAG_SERVER_REQUEST_PATH_PARAMS "server.request.path_params"
 #define DD_MULTIPLE_IP_HEADERS "_dd.multiple-ip-headers"
 #define DD_METRIC_ENABLED "_dd.appsec.enabled"
 #define DD_APPSEC_EVENTS_PREFIX "appsec.events."
@@ -104,7 +101,6 @@ static zend_string *_key_server_name_zstr;
 static zend_string *_key_http_user_agent_zstr;
 static zend_string *_key_https_zstr;
 static zend_string *_key_remote_addr_zstr;
-static zend_string *_key_server_request_path_params;
 static zend_string *_true_zstr;
 static zend_string *_false_zstr;
 static zend_string *_track_zstr;
@@ -182,8 +178,6 @@ void dd_tags_startup()
     _key_https_zstr = zend_string_init_interned(LSTRARG("HTTPS"), 1);
     _key_remote_addr_zstr =
         zend_string_init_interned(LSTRARG("REMOTE_ADDR"), 1);
-    _key_server_request_path_params = zend_string_init_interned(
-        LSTRARG(DD_TAG_SERVER_REQUEST_PATH_PARAMS), 1);
 
     // Event related strings
     _track_zstr =