Profiling is not available on PHP 7.0

Author: iamluc

loader/dd_library_loader.c

@@ -739,7 +739,7 @@ static int ddloader_api_no_check(int api_no) {
         default:
             if (!force_load || api_no < 320151012) {
                 telemetry_reason reason = api_no < 320151012 ? REASON_EOL_RUNTIME : REASON_INCOMPATIBLE_RUNTIME;
-                TELEMETRY(reason, NULL, NULL, "Found incompatible runtime (api no: %d). Supported runtimes: PHP 7.0 to 8.3", api_no);
+                TELEMETRY(reason, NULL, NULL, "Found incompatible runtime (api no: %d). Supported runtimes: PHP 7.0 to 8.4", api_no);
 
                 // If we return FAILURE, this Zend extension would be unload, BUT it would produce an error
                 // similar to "The Zend Engine API version 220100525 which is installed, is newer."

loader/tests/functional/includes/autoload.php

@@ -90,6 +90,10 @@ function use_valgrind() {
     return (bool) (isset($_SERVER['TEST_USE_VALGRIND']) ? $_SERVER['TEST_USE_VALGRIND'] : false);
 }
 
+function php_minor_version() {
+    return PHP_MAJOR_VERSION.'.'.PHP_MINOR_VERSION;
+}
+
 function skip_if_php5() {
     if (PHP_MAJOR_VERSION <= 5) {
         echo "Skip: test is not compatible with PHP 5\n";

loader/tests/functional/test_php_output.php

@@ -12,7 +12,9 @@
 $output = runCLI('-v', true);
 assertContains($output, 'with ddtrace v');
 assertContains($output, 'with dd_library_loader v');
-assertContains($output, 'with datadog-profiling v');
+if ('7.0' !== php_minor_version()) {
+    assertContains($output, 'with datadog-profiling v');
+}
 assertContains($output, 'with ddappsec v');
 
 $output = runCLI('-m', false);
@@ -24,5 +26,7 @@
 $output = runCLI('-m', true);
 assertContains($output, 'ddtrace');
 assertContains($output, 'dd_library_loader');
-assertContains($output, 'datadog-profiling');
+if ('7.0' !== php_minor_version()) {
+    assertContains($output, 'datadog-profiling');
+}
 assertContains($output, 'ddappsec');

tooling/bin/generate-ssi-package.sh

@@ -64,17 +64,19 @@ for architecture in "${architectures[@]}"; do
         # Profiling
         ########################
 
-        mkdir -p ${gnu}/profiling/ext/${php_api} ${musl}/profiling/ext/${php_api}
-        # gnu
-        ln ./datadog-profiling/${architecture}-unknown-linux-gnu/lib/php/${php_api}/datadog-profiling.so \
-            ${gnu}/profiling/ext/${php_api}/datadog-profiling.so
-        ln ./datadog-profiling/${architecture}-unknown-linux-gnu/lib/php/${php_api}/datadog-profiling-zts.so \
-            ${gnu}/profiling/ext/${php_api}/datadog-profiling-zts.so
-        # musl
-        ln ./datadog-profiling/${architecture}-alpine-linux-musl/lib/php/${php_api}/datadog-profiling.so \
-            ${musl}/profiling/ext/${php_api}/datadog-profiling.so
-        ln ./datadog-profiling/${architecture}-alpine-linux-musl/lib/php/${php_api}/datadog-profiling-zts.so \
-            ${musl}/profiling/ext/${php_api}/datadog-profiling-zts.so
+        if [[ ${php_api} -ge 20160303 ]]; then
+            mkdir -p ${gnu}/profiling/ext/${php_api} ${musl}/profiling/ext/${php_api}
+            # gnu
+            ln ./datadog-profiling/${architecture}-unknown-linux-gnu/lib/php/${php_api}/datadog-profiling.so \
+                ${gnu}/profiling/ext/${php_api}/datadog-profiling.so
+            ln ./datadog-profiling/${architecture}-unknown-linux-gnu/lib/php/${php_api}/datadog-profiling-zts.so \
+                ${gnu}/profiling/ext/${php_api}/datadog-profiling-zts.so
+            # musl
+            ln ./datadog-profiling/${architecture}-alpine-linux-musl/lib/php/${php_api}/datadog-profiling.so \
+                ${musl}/profiling/ext/${php_api}/datadog-profiling.so
+            ln ./datadog-profiling/${architecture}-alpine-linux-musl/lib/php/${php_api}/datadog-profiling-zts.so \
+                ${musl}/profiling/ext/${php_api}/datadog-profiling-zts.so
+        fi
 
         ########################
         # AppSec