Skip to content

Commit 75d0280

Browse files
committed
chore(appsec): fix CI tests
Signed-off-by: Alexandre Rulleau <[email protected]>
1 parent 831559d commit 75d0280

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

appsec/src/extension/tags.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1181,11 +1181,11 @@ static PHP_FUNCTION(datadog_appsec_track_user_login_success_event_automated)
11811181

11821182
// _dd.appsec.events.users.login.success.usr.login = <user_login>
11831183
_add_new_zstr_to_meta(
1184-
meta_ht, _dd_login_success_event_login, user_login, false, true);
1184+
meta_ht, _dd_login_success_event_login, user_login, true, true);
11851185

11861186
// _dd.appsec.usr.login = <user_login>
11871187
_add_new_zstr_to_meta(
1188-
meta_ht, _dd_appsec_user_login, user_login, true, true);
1188+
meta_ht, _dd_appsec_user_login, user_login, false, true);
11891189

11901190
// appsec.events.users.login.success.track = true
11911191
_add_custom_event_keyval(
@@ -1230,6 +1230,8 @@ static PHP_FUNCTION(datadog_appsec_track_user_login_success_event)
12301230
_user_event_triggered = true;
12311231
zend_array *meta_ht = Z_ARRVAL_P(meta);
12321232

1233+
dd_find_and_apply_verdict_for_user(user_id);
1234+
12331235
// usr.id = <user_id>
12341236
_add_new_zstr_to_meta(
12351237
meta_ht, _dd_tag_user_id, user_id, copy_user_id, true);

appsec/tests/extension/track_user_signup_event_sdk_takes_priority.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ DD_APPSEC_ENABLED=1
99
use function datadog\appsec\testing\root_span_get_meta;
1010
use function datadog\appsec\track_user_signup_event;
1111
use function datadog\appsec\track_user_signup_event_automated;
12+
1213
include __DIR__ . '/inc/ddtrace_version.php';
1314

1415
ddtrace_version_at_least('0.79.0');

appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ trait CommonTests {
6969
assert span.meta."_dd.appsec.usr.id" == 'Admin'
7070
assert span.meta."_dd.appsec.usr.login" == 'Login'
7171
assert span.meta."appsec.events.users.login.success.track" == 'true'
72-
assert span.meta."appsec.events.users.login.success.email" == '[email protected]'
73-
assert span.meta."appsec.events.users.login.success.session_id" == '987654321'
74-
assert span.meta."appsec.events.users.login.success.role" == 'admin'
7572
}
7673

7774
@Test
@@ -104,9 +101,6 @@ trait CommonTests {
104101
assert span.meta."appsec.events.users.login.failure.usr.login" == 'Login'
105102
assert span.meta."appsec.events.users.login.failure.usr.exists" == 'false'
106103
assert span.meta."appsec.events.users.login.failure.track" == 'true'
107-
assert span.meta."appsec.events.users.login.failure.email" == '[email protected]'
108-
assert span.meta."appsec.events.users.login.failure.session_id" == '987654321'
109-
assert span.meta."appsec.events.users.login.failure.role" == 'admin'
110104
}
111105

112106
@Test

0 commit comments

Comments
 (0)