More tests

We test that sampling works on resources with the same glob patterns

Also adds a test where we test all criterias in one sampling rule.

Author: pierotibou

tests/ext/priority_sampling/021-rule-name-as-glob-with-question-mark.phpt

@@ -19,6 +19,7 @@ $tests = [
     ["f*o*e", "fooname", true],
     ["f*o*m?", "fooname", true],
     ["f*x*m?", "fooname", false],
+
 ];
 
 foreach ($tests as list($pattern, $name, $matches)) {
@@ -46,7 +47,21 @@ foreach ($tests as list($pattern, $name, $matches)) {
     if ($root->metrics["_dd.rule_psr"] == ($matches ? 0.7 : 0.3)) {
         echo "As expected, $pattern " . ($matches ? "matches" : "doesn't match") . " $name (service)\n";
     } else {
-        echo "$pattern " . ($matches ? "should have matched" : "shouldn't have matched") . " $name (name). Metrics found were: \n";
+        echo "$pattern " . ($matches ? "should have matched" : "shouldn't have matched") . " $name (service). Metrics found were: \n";
+        var_dump($root->metrics);
+    }
+
+    ini_set("datadog.trace_sampling_rules", '[{"resource":"' . $pattern . '","sample_rate":0.7},{"sample_rate": 0.3]');
+
+    $root = \DDTrace\root_span();
+    $root->resource = $name;
+
+    \DDTrace\get_priority_sampling();
+
+    if ($root->metrics["_dd.rule_psr"] == ($matches ? 0.7 : 0.3)) {
+        echo "As expected, $pattern " . ($matches ? "matches" : "doesn't match") . " $name (resource)\n";
+    } else {
+        echo "$pattern " . ($matches ? "should have matched" : "shouldn't have matched") . " $name (resource). Metrics found were: \n";
         var_dump($root->metrics);
     }
 }
@@ -55,25 +70,37 @@ foreach ($tests as list($pattern, $name, $matches)) {
 --EXPECT--
 As expected, fooname matches fooname (name)
 As expected, fooname matches fooname (service)
+As expected, fooname matches fooname (resource)
 As expected, fooname** matches fooname (name)
 As expected, fooname** matches fooname (service)
+As expected, fooname** matches fooname (resource)
 As expected, **fooname matches fooname (name)
 As expected, **fooname matches fooname (service)
+As expected, **fooname matches fooname (resource)
 As expected, * matches fooname (name)
 As expected, * matches fooname (service)
+As expected, * matches fooname (resource)
 As expected, ??????? matches fooname (name)
 As expected, ??????? matches fooname (service)
+As expected, ??????? matches fooname (resource)
 As expected, ?????? doesn't match fooname (name)
 As expected, ?????? doesn't match fooname (service)
+As expected, ?????? doesn't match fooname (resource)
 As expected, ?? doesn't match fooname (name)
 As expected, ?? doesn't match fooname (service)
+As expected, ?? doesn't match fooname (resource)
 As expected, *? matches fooname (name)
 As expected, *? matches fooname (service)
+As expected, *? matches fooname (resource)
 As expected, ?* matches fooname (name)
 As expected, ?* matches fooname (service)
+As expected, ?* matches fooname (resource)
 As expected, f*o*e matches fooname (name)
 As expected, f*o*e matches fooname (service)
+As expected, f*o*e matches fooname (resource)
 As expected, f*o*m? matches fooname (name)
 As expected, f*o*m? matches fooname (service)
+As expected, f*o*m? matches fooname (resource)
 As expected, f*x*m? doesn't match fooname (name)
 As expected, f*x*m? doesn't match fooname (service)
+As expected, f*x*m? doesn't match fooname (resource)

tests/ext/priority_sampling/022-rule-name-as-glob-with-multiple-criterias.phpt

@@ -0,0 +1,40 @@
+--TEST--
+priority_sampling rule with name match, using glob
+--ENV--
+DD_TRACE_GENERATE_ROOT_SPAN=1
+DD_TRACE_SAMPLING_RULES_FORMAT=glob
+--FILE--
+<?php
+
+$tests = [
+    ["webserver.non-matching", "web.request", "/bar", false],
+    ["webserver", "web.request.non-matching", "/bar", false],
+    ["webserver", "web.request", "/bar.non-matching", false],
+    ["webserver", "web.request", "/b?r", true],
+];
+
+foreach ($tests as list($servicePattern, $namePattern, $resourcePatthern, $matches)) {
+    ini_set("datadog.trace.sampling_rules", '[{"name":"' . $namePattern . '","service":"' . $servicePattern . '","resource":"' . $resourcePatthern . '","sample_rate":0.7},{"sample_rate": 0.3}]');
+
+    $root = DDTrace\root_span();
+    $root->service = "webserver";
+    $root->name = "web.request";
+    $root->resource = "/bar";
+
+    DDTrace\get_priority_sampling();
+
+    if ($root->metrics["_dd.rule_psr"] == ($matches ? 0.7 : 0.3)) {
+        echo "As expected, rule $servicePattern, $namePattern, $resourcePatthern " . ($matches ? "matches" : "doesn't match") . "\n";
+    } else {
+        echo "Rule $servicePattern, $namePattern, $resourcePatthern " . ($matches ? "should have matched" : "shouldn't have matched") . "\n";
+        var_dump($root->metrics);
+    }
+
+}
+?>
+
+--EXPECT--
+As expected, rule webserver.non-matching, web.request, /bar doesn't match
+As expected, rule webserver, web.request.non-matching, /bar doesn't match
+As expected, rule webserver, web.request, /bar.non-matching doesn't match
+As expected, rule webserver, web.request, /b?r matches