Minify blocking json message

estringana · estringana · commit ad6b3be58293 · 2025-11-28T11:51:37.000+01:00
diff --git a/appsec/src/extension/request_abort.c b/appsec/src/extension/request_abort.c
@@ -60,9 +60,9 @@ static const char static_error_html[] =
     "target=\"_blank\">Datadog</a></p></footer></body></html>";
 
 static const char static_error_json[] =
-    "{\"errors\": [{\"title\": \"You've been blocked\", \"detail\": \"Sorry, yo"
+    "{\"errors\":[{\"title\":\"You've been blocked\",\"detail\":\"Sorry, yo"
     "u cannot access this page. Please contact the customer service team. Secur"
-    "ity provided by Datadog.\"}], \"security_response_id\": "
+    "ity provided by Datadog.\"}],\"security_response_id\":"
     "\"[security_response_id]\"}";
 
 static zend_string *_initial_cwd;
diff --git a/appsec/tests/extension/push_params_block_01.phpt b/appsec/tests/extension/push_params_block_01.phpt
@@ -25,5 +25,5 @@ var_dump("THIS SHOULD NOT GET IN THE OUTPUT");
 Status: 404 Not Found
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\push_addresses(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/push_params_block_04.phpt b/appsec/tests/extension/push_params_block_04.phpt
@@ -25,5 +25,5 @@ var_dump("THIS SHOULD NOT GET IN THE OUTPUT");
 Status: 404 Not Found
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": "some-id-here"}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":"some-id-here"}
 Warning: datadog\appsec\push_addresses(): Datadog blocked the request and presented a static error page. No action required. Security Response ID: some-id-here in %s on line %d
diff --git a/appsec/tests/extension/req_abort_empty_custom_json_template.phpt b/appsec/tests/extension/req_abort_empty_custom_json_template.phpt
@@ -21,5 +21,5 @@ rinit();
 Status: 500 Internal Server Error
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\rinit(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_from_rinit_auto.phpt b/appsec/tests/extension/req_abort_from_rinit_auto.phpt
@@ -19,5 +19,5 @@ rinit();
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\rinit(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_from_rinit_invalid_content_type.phpt b/appsec/tests/extension/req_abort_from_rinit_invalid_content_type.phpt
@@ -20,5 +20,5 @@ rinit();
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\rinit(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_from_rinit_invalid_status_code.phpt b/appsec/tests/extension/req_abort_from_rinit_invalid_status_code.phpt
@@ -20,5 +20,5 @@ rinit();
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\rinit(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_from_rinit_json_404.phpt b/appsec/tests/extension/req_abort_from_rinit_json_404.phpt
@@ -19,5 +19,5 @@ rinit();
 Status: 404 Not Found
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\rinit(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_from_rshutdown_auto.phpt b/appsec/tests/extension/req_abort_from_rshutdown_auto.phpt
@@ -23,4 +23,4 @@ rshutdown();
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
diff --git a/appsec/tests/extension/req_abort_from_user_login_success_event.phpt b/appsec/tests/extension/req_abort_from_user_login_success_event.phpt
@@ -36,5 +36,5 @@ echo "SHOULD NOT BE REACHED\n";
 Status: 404 Not Found
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\track_user_login_success_event(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_mid_request_auto.phpt b/appsec/tests/extension/req_abort_mid_request_auto.phpt
@@ -9,5 +9,5 @@ THIS SHOULD NOT BE REACHED
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\abort_static_page(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_mid_request_json.phpt b/appsec/tests/extension/req_abort_mid_request_json.phpt
@@ -11,5 +11,5 @@ THIS SHOULD NOT BE REACHED
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\abort_static_page(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_mid_request_json_fallback.phpt b/appsec/tests/extension/req_abort_mid_request_json_fallback.phpt
@@ -11,5 +11,5 @@ THIS SHOULD NOT BE REACHED
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\abort_static_page(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_mid_request_json_multiaccept.phpt b/appsec/tests/extension/req_abort_mid_request_json_multiaccept.phpt
@@ -11,5 +11,5 @@ THIS SHOULD NOT BE REACHED
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\abort_static_page(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_mid_request_json_weight.phpt b/appsec/tests/extension/req_abort_mid_request_json_weight.phpt
@@ -11,5 +11,5 @@ THIS SHOULD NOT BE REACHED
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\abort_static_page(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_redirection_03.phpt b/appsec/tests/extension/req_abort_redirection_03.phpt
@@ -22,5 +22,5 @@ Some content here which should not be displayed
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\rinit(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_redirection_04.phpt b/appsec/tests/extension/req_abort_redirection_04.phpt
@@ -22,5 +22,5 @@ Some content here which should be displayed
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\rinit(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/req_abort_redirection_05.phpt b/appsec/tests/extension/req_abort_redirection_05.phpt
@@ -22,5 +22,5 @@ Some content here which should not be displayed
 Status: 403 Forbidden
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\testing\rinit(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/user_req_basic_01.phpt b/appsec/tests/extension/user_req_basic_01.phpt
@@ -75,23 +75,23 @@ Result of notify_start:
 Array
 (
     [status] => 403
-    [body] => {"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+    [body] => {"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
     [headers] => Array
         (
             [Content-Type] => application/json
-            [Content-Length] => 195
+            [Content-Length] => 189
         )
 
 )
 Result of notify_commit:
 Array
 (
     [status] => 403
-    [body] => {"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+    [body] => {"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
     [headers] => Array
         (
             [Content-Type] => application/json
-            [Content-Length] => 195
+            [Content-Length] => 189
         )
 
 )
diff --git a/appsec/tests/extension/user_req_basic_02.phpt b/appsec/tests/extension/user_req_basic_02.phpt
@@ -75,23 +75,23 @@ Result of notify_start:
 Array
 (
     [status] => 403
-    [body] => {"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+    [body] => {"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
     [headers] => Array
         (
             [Content-Type] => application/json
-            [Content-Length] => 195
+            [Content-Length] => 189
         )
 
 )
 Result of notify_commit:
 Array
 (
     [status] => 403
-    [body] => {"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+    [body] => {"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
     [headers] => Array
         (
             [Content-Type] => application/json
-            [Content-Length] => 195
+            [Content-Length] => 189
         )
 
 )
diff --git a/appsec/tests/extension/user_tracking_block_from_login_failure_v2.phpt b/appsec/tests/extension/user_tracking_block_from_login_failure_v2.phpt
@@ -35,5 +35,5 @@ echo "SHOULD NOT BE REACHED\n";
 Status: 404 Not Found
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\v2\track_user_login_failure(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/user_tracking_block_from_login_success.phpt b/appsec/tests/extension/user_tracking_block_from_login_success.phpt
@@ -36,5 +36,5 @@ echo "SHOULD NOT BE REACHED\n";
 Status: 404 Not Found
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\track_user_login_success_event(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/user_tracking_block_from_login_success_v2.phpt b/appsec/tests/extension/user_tracking_block_from_login_success_v2.phpt
@@ -35,5 +35,5 @@ echo "SHOULD NOT BE REACHED\n";
 Status: 404 Not Found
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: datadog\appsec\v2\track_user_login_success(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/extension/user_tracking_block_from_set_user.phpt b/appsec/tests/extension/user_tracking_block_from_set_user.phpt
@@ -34,5 +34,5 @@ echo "SHOULD NOT BE REACHED\n";
 Status: 404 Not Found
 Content-type: application/json
 --EXPECTF--
-{"errors": [{"title": "You've been blocked", "detail": "Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}], "security_response_id": ""}
+{"errors":[{"title":"You've been blocked","detail":"Sorry, you cannot access this page. Please contact the customer service team. Security provided by Datadog."}],"security_response_id":""}
 Warning: DDTrace\set_user(): Datadog blocked the request and presented a static error page. No action required. Security Response ID:  in %s on line %d
diff --git a/appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/WorkerStrategyTests.groovy b/appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/WorkerStrategyTests.groovy
@@ -46,7 +46,7 @@ trait WorkerStrategyTests {
         HttpRequest req = container.buildReq('/')
                 .header('X-Forwarded-For', '80.80.80.80').GET().build()
         def trace = container.traceFromRequest(req, ofString()) { HttpResponse<String> re ->
-            assert re.body().contains('"title": "You\'ve been blocked"')
+            assert re.body().contains('"title":"You\'ve been blocked"')
             assert re.statusCode() == 403
             assert re.headers().firstValue('Content-type').get() == 'application/json'
         }
