fix off by one

realFlowControl · realFlowControl · commit c5e87b1ea144 · 2025-11-28T11:45:20.000+01:00
diff --git a/appsec/src/extension/request_abort.c b/appsec/src/extension/request_abort.c
@@ -515,8 +515,9 @@ zend_array *nonnull dd_request_abort_static_page_spec(
     }
 
     {
-        char buf[sizeof("18446744073709551615") - 1];
-        size_t len = sprintf(buf, "%zu", body_len);
+        // This magic number is the string representation of SIZE_MAX on 64 bit systems
+        char buf[sizeof("18446744073709551615")];
+        size_t len = snprintf(buf, sizeof(buf), "%zu", body_len);
         zend_string *s = zend_string_init(buf, len, 0);
         zval cont_len_zv;
         ZVAL_STR(&cont_len_zv, s);

Original file line number	Diff line number	Diff line change
`@@ -515,8 +515,9 @@ zend_array *nonnull dd_request_abort_static_page_spec(`
`515`	`515`	`}`
`516`	`516`
`517`	`517`	`{`
`518`		`- char buf[sizeof("18446744073709551615") - 1];`
`519`		`- size_t len = sprintf(buf, "%zu", body_len);`
	`518`	`+ // This magic number is the string representation of SIZE_MAX on 64 bit systems`
	`519`	`+ char buf[sizeof("18446744073709551615")];`
	`520`	`+ size_t len = snprintf(buf, sizeof(buf), "%zu", body_len);`
`520`	`521`	`zend_string *s = zend_string_init(buf, len, 0);`
`521`	`522`	`zval cont_len_zv;`
`522`	`523`	`ZVAL_STR(&cont_len_zv, s);`