Skip to content

Commit dc9911b

Browse files
authored
Upgrade libddwaf to v1.22.0 (#3007)
1 parent 0d57b55 commit dc9911b

File tree

5 files changed

+19
-6
lines changed

5 files changed

+19
-6
lines changed

appsec/tests/helper/client_test.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -2760,7 +2760,7 @@ TEST(ClientTest, RaspCalls)
27602760
dynamic_cast<network::request_shutdown::response *>(res.get());
27612761

27622762
EXPECT_EQ(msg_res->metrics.size(), 3);
2763-
EXPECT_GT(msg_res->metrics[metrics::waf_duration], 0.0);
2763+
EXPECT_GE(msg_res->metrics[metrics::waf_duration], 0.0);
27642764
EXPECT_EQ(msg_res->metrics[metrics::rasp_rule_eval], 1);
27652765
EXPECT_GE(msg_res->metrics[metrics::rasp_duration], 0.0);
27662766
}

appsec/tests/helper/waf_test.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,10 @@ TEST(WafTest, RunWithTimeout)
117117

118118
EXPECT_CALL(submitm, submit_span_metric(metrics::rasp_timeout, 1));
119119
EXPECT_CALL(submitm, submit_span_metric(metrics::rasp_rule_eval, 1.0));
120-
EXPECT_CALL(submitm, submit_span_metric(metrics::waf_duration, 0.0));
121-
EXPECT_CALL(submitm, submit_span_metric(metrics::rasp_duration, 0.0));
120+
// Since v1.22.0 libddwaf will still attempt to run denylists, which
121+
// will cause the duration to be non-zero
122+
EXPECT_CALL(submitm, submit_span_metric(metrics::waf_duration, _));
123+
EXPECT_CALL(submitm, submit_span_metric(metrics::rasp_duration, _));
122124
parameter_view pv(p);
123125
dds::event e;
124126
bool is_rasp = true;

appsec/tests/integration/src/test/groovy/com/datadog/appsec/php/integration/CommonTests.groovy

+1-1
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ trait CommonTests {
181181

182182
@Test
183183
void 'test blocking and stack generation'() {
184-
HttpRequest req = container.buildReq('/generate_stack.php?id=user2020').GET().build()
184+
HttpRequest req = container.buildReq('/generate_stack.php?id=stack_user').GET().build()
185185
def trace = container.traceFromRequest(req, ofString()) { HttpResponse<String> re ->
186186
assert re.statusCode() == 403
187187
assert re.body().contains('blocked')

appsec/tests/integration/src/test/waf/recommended.json

+12-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"address": "usr.id"
4545
}
4646
],
47-
"data": "blocked_users"
47+
"data": "blocked_users_with_stack"
4848
},
4949
"operator": "exact_match"
5050
}
@@ -6894,6 +6894,17 @@
68946894
}
68956895
]
68966896
},
6897+
{
6898+
"id": "blocked_users_with_stack",
6899+
"type": "data_with_expiration",
6900+
"data": [
6901+
{
6902+
"value": "stack_user",
6903+
"expiration": 0
6904+
}
6905+
]
6906+
},
6907+
68976908
{
68986909
"id": "redirected_users",
68996910
"type": "data_with_expiration",

appsec/third_party/libddwaf

Submodule libddwaf updated 900 files

0 commit comments

Comments
 (0)