Skip to content

Commit

Permalink
build(prof): bump libdatadog to version 15 (#3048)
Browse files Browse the repository at this point in the history
* bump libdatadog to version `15`

* fix setup-php version
  • Loading branch information
realFlowControl authored Jan 21, 2025
1 parent 6b36477 commit e44d78d
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 106 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/prof_correctness.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
submodules: true

- name: Setup PHP
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@2.32.0
with:
php-version: ${{ matrix.php-version }}
extensions: ${{ matrix.extensions }}
Expand Down
122 changes: 24 additions & 98 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions profiling/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ cfg-if = { version = "1.0" }
cpu-time = { version = "1.0" }
chrono = { version = "0.4" }
crossbeam-channel = { version = "0.5", default-features = false, features = ["std"] }
datadog-alloc = { git = "https://github.com/DataDog/libdatadog", tag = "v10.0.0" }
datadog-profiling = { git = "https://github.com/DataDog/libdatadog", tag = "v10.0.0" }
ddcommon = { git = "https://github.com/DataDog/libdatadog", tag = "v10.0.0" }
datadog-alloc = { git = "https://github.com/DataDog/libdatadog", tag = "v15.0.0" }
datadog-profiling = { git = "https://github.com/DataDog/libdatadog", tag = "v15.0.0" }
ddcommon = { git = "https://github.com/DataDog/libdatadog", tag = "v15.0.0" }
env_logger = { version = "0.11", default-features = false }
indexmap = { version = "2.2" }
lazy_static = { version = "1.4" }
Expand Down
6 changes: 2 additions & 4 deletions profiling/src/profiling/uploader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ use std::borrow::Cow;
use std::str;
use std::sync::atomic::Ordering;
use std::sync::{Arc, Barrier};
use std::time::Duration;

pub struct Uploader {
fork_barrier: Arc<Barrier>,
Expand Down Expand Up @@ -70,7 +69,7 @@ impl Uploader {
let endpoint = Endpoint::try_from(agent_endpoint)?;

let tags = Some(Arc::unwrap_or_clone(index.tags));
let exporter = datadog_profiling::exporter::ProfileExporter::new(
let mut exporter = datadog_profiling::exporter::ProfileExporter::new(
profiling_library_name,
profiling_library_version,
"php",
Expand All @@ -87,7 +86,7 @@ impl Uploader {
name: "profile.pprof",
bytes: serialized.buffer.as_slice(),
}];
let timeout = Duration::from_secs(10);
exporter.set_timeout(10000); // 10 seconds in milliseconds
let request = exporter.build(
start,
end,
Expand All @@ -97,7 +96,6 @@ impl Uploader {
endpoint_counts,
Self::create_internal_metadata(),
self.create_profiler_info(),
timeout,
)?;
debug!("Sending profile to: {agent_endpoint}");
let result = exporter.send(request, None)?;
Expand Down

0 comments on commit e44d78d

Please sign in to comment.