Skip to content

Commit f1126a6

Browse files
estringanaestringana
committed
Fix failing tests
1 parent 616b22a commit f1126a6

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

Diff for: ‎tests/Appsec/Mock.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public function getEvents(array $names = [], array $addresses = [])
7676
foreach ($events as $event) {
7777
$new = json_decode($event['event'], true);
7878
if (empty($names) || in_array($new['eventName'], $names) &&
79-
(empty($addresses) || !empty(array_intersect($addresses, array_keys($new))))) {
79+
(empty($addresses) || !empty(array_intersect($addresses, array_keys($new[0]))))) {
8080
$result[] = $new;
8181
}
8282
}

Diff for: ‎tests/Integrations/Laravel/PathParamsTestSuite.php

+7-7
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ public function testDynamicRouteWithAllParametersGiven()
1515
$this->call(
1616
GetSpec::create('Call to dynamic route', "/dynamic_route/$param01/static/$param02")
1717
);
18-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
18+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
1919
$this->assertEquals(1, count($events));
20-
$this->assertEquals($param01, $events[0]["server.request.path_params"]['param01']);
21-
$this->assertEquals($param02, $events[0]["server.request.path_params"]['param02']);
20+
$this->assertEquals($param01, $events[0][0]["server.request.path_params"]['param01']);
21+
$this->assertEquals($param02, $events[0][0]["server.request.path_params"]['param02']);
2222
}
2323

2424
public function testDynamicRouteWithOptionalParametersNotGiven()
@@ -27,18 +27,18 @@ public function testDynamicRouteWithOptionalParametersNotGiven()
2727
$this->call(
2828
GetSpec::create('Call to dynamic route', "/dynamic_route/$param01/static")
2929
);
30-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
30+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
3131
$this->assertEquals(1, count($events));
32-
$this->assertCount(1, $events[0]["server.request.path_params"]);
33-
$this->assertEquals($param01, $events[0]["server.request.path_params"]['param01']);
32+
$this->assertCount(1, $events[0][0]["server.request.path_params"]);
33+
$this->assertEquals($param01, $events[0][0]["server.request.path_params"]['param01']);
3434
}
3535

3636
public function testStaticRouteDoesNotGenerateEvent()
3737
{
3838
$this->call(
3939
GetSpec::create('Call to static route', "/simple")
4040
);
41-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
41+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
4242
$this->assertEquals(0, count($events));
4343
}
4444
}

Diff for: ‎tests/Integrations/Symfony/PathParamsTestSuite.php

+7-7
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,26 @@ public function testDynamicRouteWithOptionalsFilled()
1717
$param01 = 'first_param';
1818
$param02 = 'second_param';
1919
$this->call(GetSpec::create('dynamic', "/dynamic_route/$param01/$param02"));
20-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
20+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
2121
$this->assertEquals(1, count($events));
22-
$this->assertEquals($param01, $events[0]["server.request.path_params"]['param01']);
23-
$this->assertEquals($param02, $events[0]["server.request.path_params"]['param02']);
22+
$this->assertEquals($param01, $events[0][0]["server.request.path_params"]['param01']);
23+
$this->assertEquals($param02, $events[0][0]["server.request.path_params"]['param02']);
2424
}
2525

2626
public function testDynamicRouteWithOptionalsNotFilled()
2727
{
2828
$param01 = 'first_param';
2929
$this->call(GetSpec::create('dynamic', "/dynamic_route/$param01"));
30-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
30+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
3131
$this->assertEquals(1, count($events));
32-
$this->assertEquals($param01, $events[0]["server.request.path_params"]['param01']);
33-
$this->assertEmpty($events[0]["server.request.path_params"]['param02']);
32+
$this->assertEquals($param01, $events[0][0]["server.request.path_params"]['param01']);
33+
$this->assertEmpty($events[0][0]["server.request.path_params"]['param02']);
3434
}
3535

3636
public function testStaticRoute()
3737
{
3838
$this->call(GetSpec::create('static', "/simple"));
39-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
39+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
4040
$this->assertEquals(0, count($events));
4141
}
4242
}

Diff for: ‎tests/Integrations/WordPress/PathParamsTestSuite.php

+7-7
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ public function testPost()
1717
)
1818
);
1919

20-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
20+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
2121
$this->assertEquals(1, count($events));
22-
$this->assertEquals('hello-world', $events[0]["server.request.path_params"]['name']);
22+
$this->assertEquals('hello-world', $events[0][0]["server.request.path_params"]['name']);
2323
}
2424

2525
public function testCategory()
@@ -31,9 +31,9 @@ public function testCategory()
3131
)
3232
);
3333

34-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
34+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
3535
$this->assertEquals(1, count($events));
36-
$this->assertEquals('uncategorized', $events[0]["server.request.path_params"]['category_name']);
36+
$this->assertEquals('uncategorized', $events[0][0]["server.request.path_params"]['category_name']);
3737
}
3838

3939
public function testAuthor()
@@ -45,9 +45,9 @@ public function testAuthor()
4545
)
4646
);
4747

48-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
48+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
4949
$this->assertEquals(1, count($events));
50-
$this->assertEquals('test', $events[0]["server.request.path_params"]['author_name']);
50+
$this->assertEquals('test', $events[0][0]["server.request.path_params"]['author_name']);
5151
}
5252

5353
public function testNonExistingPost()
@@ -59,7 +59,7 @@ public function testNonExistingPost()
5959
)
6060
);
6161

62-
$events = AppsecStatus::getInstance()->getEvents(['push_address'], ['server.request.path_params']);
62+
$events = AppsecStatus::getInstance()->getEvents(['push_addresses'], ['server.request.path_params']);
6363
$this->assertEquals(0, count($events));
6464
}
6565
}

0 commit comments

Comments
 (0)