Skip to content

Commit 3e8c16a

Browse files
committed
remove fix, evan can fix this when he comes back
1 parent 2a8aa8d commit 3e8c16a

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

tests/contrib/botocore/test_bedrock_llmobs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,7 @@ def test_llmobs_converse(cls, bedrock_client, request_vcr, mock_tracer, llmobs_e
741741
span = mock_tracer.pop_traces()[0][0]
742742
assert len(llmobs_events) == 1
743743

744-
assert llmobs_events[0] == _expected_llmobs_llm_span_event(
744+
llmobs_events[0] == _expected_llmobs_llm_span_event(
745745
span,
746746
model_name="claude-3-sonnet-20240229-v1:0",
747747
model_provider="anthropic",
@@ -819,7 +819,7 @@ def test_llmobs_converse_stream(cls, bedrock_client, request_vcr, mock_tracer, l
819819
span = mock_tracer.pop_traces()[0][0]
820820
assert len(llmobs_events) == 1
821821

822-
assert llmobs_events[0] == _expected_llmobs_llm_span_event(
822+
llmobs_events[0] == _expected_llmobs_llm_span_event(
823823
span,
824824
model_name="claude-3-sonnet-20240229-v1:0",
825825
model_provider="anthropic",

tests/llmobs/test_llmobs_evaluator_runner.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,22 +98,16 @@ def test_evaluator_runner_on_exit(mock_writer_logs, run_python_code_in_subproces
9898
env.update({"PYTHONPATH": ":".join(pypath), "_DD_LLMOBS_EVALUATOR_INTERVAL": "5"})
9999
out, err, status, pid = run_python_code_in_subprocess(
100100
"""
101-
import os
102-
import time
103-
import atexit
104-
import mock
105101
from ddtrace.llmobs import LLMObs
106102
from ddtrace.llmobs._evaluators.runner import EvaluatorRunner
107103
from tests.llmobs._utils import logs_vcr
108104
from tests.llmobs._utils import DummyEvaluator
109105
110-
ctx = logs_vcr.use_cassette("tests.llmobs.test_llmobs_evaluator_runner.send_score_metric.yaml")
111-
ctx.__enter__()
112-
atexit.register(lambda: ctx.__exit__())
113-
LLMObs.enable(api_key="dummy-api-key", site="datad0g.com", ml_app="unnamed-ml-app")
114-
LLMObs._instance._evaluator_runner.evaluators.append(DummyEvaluator(llmobs_service=LLMObs))
115-
LLMObs._instance._evaluator_runner.start()
116-
LLMObs._instance._evaluator_runner.enqueue({"span_id": "123", "trace_id": "1234"}, None)
106+
with logs_vcr.use_cassette("tests.llmobs.test_llmobs_evaluator_runner.send_score_metric.yaml"):
107+
LLMObs.enable(api_key="dummy-api-key", site="datad0g.com", ml_app="unnamed-ml-app")
108+
LLMObs._instance._evaluator_runner.evaluators.append(DummyEvaluator(llmobs_service=LLMObs))
109+
LLMObs._instance._evaluator_runner.start()
110+
LLMObs._instance._evaluator_runner.enqueue({"span_id": "123", "trace_id": "1234"}, None)
117111
""",
118112
env=env,
119113
)

0 commit comments

Comments
 (0)