Skip to content

Commit 78d35a2

Browse files
authored
chore: extend pyramid flaky test timestamp (#11369)
The pyramid test flaky marker was set to Jan 2024 so it is expired by now. This PR updates the test. While looking at the failed pipelines, example: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/703862626 One of the reasons it fails is because there's a new base service name and it is no longer blank: ``` meta mismatch on '_dd.base_service': got 'tests.contrib.pyramid.app' which does not match expected ''. ``` Related to #11274 Also, this PR sets a new flaky timestamp because the pyramid sample app doesn't spin up correctly in the subprocesses, leading to failed tests. Relates to AIDM-483 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 7e1bb89 commit 78d35a2

2 files changed

+2
-2
lines changed

tests/contrib/pyramid/test_pyramid.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ def pyramid_client(snapshot, pyramid_app):
253253
proc.terminate()
254254

255255

256-
@flaky(until=1706677200)
256+
@flaky(1740089353, reason="Sample app doesn't seem to spin up in subprocess")
257257
@pytest.mark.parametrize(
258258
"pyramid_app",
259259
[

tests/snapshots/tests.contrib.pyramid.test_pyramid.test_simple_pyramid_app_endpoint[ddtrace-run_python_tests_contrib_pyramid_app_app.py].json

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"type": "web",
1010
"error": 0,
1111
"meta": {
12-
"_dd.base_service": "",
12+
"_dd.base_service": "tests.contrib.pyramid.app",
1313
"_dd.p.dm": "-0",
1414
"_dd.p.tid": "654a694400000000",
1515
"component": "pyramid",

0 commit comments

Comments
 (0)