You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(langchain): drop support for tracing langchain.chains (#12172)
This PR drops support for tracing `langchain.chains` in favor of only
tracing `RunnableSequence` (LangChain Expression Language - LCEL)
chains.
High LOC - this PR also re-introduces APM tracing tests for langchain,
but removes all cassettes and snapshots related to previous `langchain`
patching. We still need to refactor `conftest` a bit to be more modern,
and re-introduce LLMObs tests. I'm fairly certain those ones are flaky,
while the normal APM tests _should_ be OK.
**Known issue**: This PR effectively removes all patching on the
`langchain` package, and only patches `langchain_core` and community and
partner libraries. However, to trigger patching, you must still:
```python
import langchain
```
in order to trigger patching for LangChain. This will be fixed in a
patch in `ddtrace` 3.x.
MLOB-2140
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
0 commit comments