Skip to content

Commit 94a7494

Browse files
committed
simpler span proxying code
1 parent 2f07b12 commit 94a7494

File tree

1 file changed

+5
-13
lines changed
  • ddtrace/contrib/internal/dd_trace_api

1 file changed

+5
-13
lines changed

ddtrace/contrib/internal/dd_trace_api/patch.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,11 @@
1919

2020
def _proxy_span_arguments(args: List, kwargs: Dict) -> Tuple[List, Dict]:
2121
"""Convert all dd_trace_api.Span objects in the args/kwargs collections to their held ddtrace.Span objects"""
22-
proxied_args = []
23-
for arg in args:
24-
if isinstance(arg, dd_trace_api.Span):
25-
proxied_args.append(_STUB_TO_REAL[arg])
26-
else:
27-
proxied_args.append(arg)
28-
proxied_kwargs = {}
29-
for name, kwarg in kwargs.items():
30-
if isinstance(kwarg, dd_trace_api.Span):
31-
proxied_kwargs[name] = _STUB_TO_REAL[kwarg]
32-
else:
33-
proxied_kwargs[name] = kwarg
34-
return proxied_args, proxied_kwargs
22+
23+
def convert(arg):
24+
return _STUB_TO_REAL[arg] if isinstance(arg, dd_trace_api.Span) else arg
25+
26+
return [convert(arg) for arg in args], {name: convert(kwarg) for name, kwarg in kwargs.items()}
3527

3628

3729
def _call_on_real_instance(

0 commit comments

Comments
 (0)