Skip to content

Commit a58f139

Browse files
authored
fix(profiling): remove _self_acquired_at after use (#11898)
## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent d7927e6 commit a58f139

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

ddtrace/profiling/collector/_lock.py

+1
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ def _release(self, inner_func, *args, **kwargs):
185185
# _self_acquired_at is only set when the acquire was captured
186186
# if it's not set, we're not capturing the release
187187
start = self._self_acquired_at
188+
del self._self_acquired_at
188189

189190
try:
190191
return inner_func(*args, **kwargs)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
profiling: resolves an issue where lock release would have been captured
5+
with a wrong acquire timestamp

0 commit comments

Comments
 (0)