Skip to content

Commit a604d93

Browse files
authored
feat(symdb): enable by default (#12231)
We make Symbol Database enabled by default. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 6b76dc5 commit a604d93

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

ddtrace/settings/symbol_db.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class SymbolDatabaseConfig(En):
1111
enabled = En.v(
1212
bool,
1313
"upload_enabled",
14-
default=False,
14+
default=True,
1515
help_type="Boolean",
1616
help="Whether to upload source code symbols to the Datadog backend",
1717
)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
features:
3+
- |
4+
Symbol Database is now enabled by default.

tests/telemetry/test_writer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ def test_app_started_event_configuration_override(test_agent_session, run_python
420420
"value": str(file),
421421
},
422422
{"name": "DD_SYMBOL_DATABASE_INCLUDES", "origin": "default", "value": "set()"},
423-
{"name": "DD_SYMBOL_DATABASE_UPLOAD_ENABLED", "origin": "default", "value": False},
423+
{"name": "DD_SYMBOL_DATABASE_UPLOAD_ENABLED", "origin": "default", "value": True},
424424
{"name": "DD_TAGS", "origin": "env_var", "value": "team:apm,component:web"},
425425
{"name": "DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLED", "origin": "default", "value": True},
426426
{"name": "DD_TELEMETRY_HEARTBEAT_INTERVAL", "origin": "default", "value": 60},

0 commit comments

Comments
 (0)