chore(asm): remove deprecated env var (#12120)

remove deprecated env var DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING for
3.0 release.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Author: christophe-papazian

ddtrace/appsec/_constants.py

@@ -92,9 +92,6 @@ class APPSEC(metaclass=Constant_Class):
     ] = "_dd.appsec.events.users.login.failure.auto.mode"
     BLOCKED: Literal["appsec.blocked"] = "appsec.blocked"
     EVENT: Literal["appsec.event"] = "appsec.event"
-    AUTOMATIC_USER_EVENTS_TRACKING: Literal[
-        "DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING"
-    ] = "DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING"
     AUTO_USER_INSTRUMENTATION_MODE: Literal[
         "DD_APPSEC_AUTO_USER_INSTRUMENTATION_MODE"
     ] = "DD_APPSEC_AUTO_USER_INSTRUMENTATION_MODE"

ddtrace/settings/asm.py

@@ -16,9 +16,7 @@
 from ddtrace.appsec._constants import LOGIN_EVENTS_MODE
 from ddtrace.appsec._constants import TELEMETRY_INFORMATION_NAME
 from ddtrace.constants import APPSEC_ENV
-from ddtrace.internal.utils.deprecations import DDTraceDeprecationWarning
 from ddtrace.settings._core import report_telemetry as _report_telemetry
-from ddtrace.vendor.debtcollector import deprecate
 
 
 def _validate_non_negative_int(r: int) -> None:
@@ -75,34 +73,6 @@ class ASMConfig(Env):
     _appsec_standalone_enabled = Env.var(bool, APPSEC.STANDALONE_ENV, default=False)
     _use_metastruct_for_triggers = True
 
-    _automatic_login_events_mode = Env.var(str, APPSEC.AUTOMATIC_USER_EVENTS_TRACKING, default="", parser=str.lower)
-    # Deprecation phase, to be removed in ddtrace 3.0.0
-    if _automatic_login_events_mode is not None:
-        if _automatic_login_events_mode == "extended":
-            deprecate(
-                "Using DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING=extended is deprecated",
-                message="Please use 'DD_APPSEC_AUTO_USER_INSTRUMENTATION_MODE=identification instead",
-                removal_version="3.0.0",
-                category=DDTraceDeprecationWarning,
-            )
-            _automatic_login_events_mode = LOGIN_EVENTS_MODE.IDENT
-        elif _automatic_login_events_mode == "safe":
-            deprecate(
-                "Using DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING=safe is deprecated",
-                message="Please use 'DD_APPSEC_AUTO_USER_INSTRUMENTATION_MODE=anonymisation instead",
-                removal_version="3.0.0",
-                category=DDTraceDeprecationWarning,
-            )
-            _automatic_login_events_mode = LOGIN_EVENTS_MODE.ANON
-        elif _automatic_login_events_mode == "disabled":
-            deprecate(
-                "Using DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING=disabled is deprecated",
-                message="Please use 'DD_APPSEC_AUTO_USER_INSTRUMENTATION_MODE=disabled"
-                " instead or DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING_ENABLED=false"
-                " to disable the feature and bypass Remote Config",
-                removal_version="3.0.0",
-                category=DDTraceDeprecationWarning,
-            )
     _auto_user_instrumentation_local_mode = Env.var(
         str,
         APPSEC.AUTO_USER_INSTRUMENTATION_MODE,
@@ -209,7 +179,6 @@ class ASMConfig(Env):
         "_iast_telemetry_report_lvl",
         "_ep_enabled",
         "_use_metastruct_for_triggers",
-        "_automatic_login_events_mode",
         "_auto_user_instrumentation_local_mode",
         "_auto_user_instrumentation_rc_mode",
         "_auto_user_instrumentation_enabled",
@@ -250,9 +219,6 @@ def __init__(self):
         super().__init__()
         # Is one click available?
         self._eval_asm_can_be_enabled()
-        # Only for deprecation phase
-        if self._automatic_login_events_mode and APPSEC.AUTO_USER_INSTRUMENTATION_MODE not in os.environ:
-            self._auto_user_instrumentation_local_mode = self._automatic_login_events_mode
         if not self._asm_libddwaf_available:
             self._asm_enabled = False
             self._asm_can_be_enabled = False

releasenotes/notes/removal_of_DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING-c1b4d2141ee92add.yaml

@@ -0,0 +1,5 @@
+---
+deprecations:
+  - |
+    ASM: deprecated env var DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING is now removed.
+    Please use the new env var DD_APPSEC_AUTO_USER_INSTRUMENTATION_MODE instead.

tests/telemetry/test_writer.py

@@ -291,7 +291,6 @@ def test_app_started_event_configuration_override(test_agent_session, run_python
         {"name": "DD_API_SECURITY_ENABLED", "origin": "default", "value": True},
         {"name": "DD_API_SECURITY_PARSE_RESPONSE_BODY", "origin": "default", "value": True},
         {"name": "DD_API_SECURITY_SAMPLE_DELAY", "origin": "default", "value": 30.0},
-        {"name": "DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING", "origin": "default", "value": ""},
         {"name": "DD_APPSEC_AUTOMATED_USER_EVENTS_TRACKING_ENABLED", "origin": "default", "value": True},
         {"name": "DD_APPSEC_AUTO_USER_INSTRUMENTATION_MODE", "origin": "default", "value": "identification"},
         {"name": "DD_APPSEC_ENABLED", "origin": "env_var", "value": True},