Release note, tests

Author: Yun-Kim

ddtrace/llmobs/_writer.py

@@ -1,5 +1,4 @@
 import atexit
-import http.client as httplib
 from typing import Any
 from typing import Dict
 from typing import List
@@ -19,6 +18,7 @@
 from ddtrace.internal import forksafe
 from ddtrace.internal.logger import get_logger
 from ddtrace.internal.periodic import PeriodicService
+from ddtrace.internal.utils.http import Response
 from ddtrace.internal.utils.http import get_connection
 from ddtrace.internal.utils.retry import fibonacci_backoff_with_jitter
 from ddtrace.llmobs import _telemetry as telemetry
@@ -132,7 +132,7 @@ def __init__(
         self._send_payload_with_retry = fibonacci_backoff_with_jitter(
             attempts=self.RETRY_ATTEMPTS,
             initial_wait=0.618 * self.interval / (1.618**self.RETRY_ATTEMPTS) / 2,
-            until=lambda result: isinstance(result, httplib.HTTPResponse),
+            until=lambda result: isinstance(result, Response),
         )(self._send_payload)
 
     def start(self, *args, **kwargs):
@@ -217,7 +217,7 @@ def _send_payload(self, payload: bytes, num_events: int):
                 telemetry.record_dropped_payload(num_events, event_type=self.EVENT_TYPE, error="http_error")
             else:
                 logger.debug("sent %d LLMObs %s events to %s", num_events, self.EVENT_TYPE, self._url)
-            return resp
+            return Response.from_http_response(resp)
         except Exception:
             logger.error(
                 "failed to send %d LLMObs %s events to %s", num_events, self.EVENT_TYPE, self._intake, exc_info=True

releasenotes/notes/fix-llmobs-unix-agent-2b959d436e6474c3.yaml

@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    LLM Observability: Resolves an issue where spans and evaluation metrics were not being sent via Unix sockets.

tests/llmobs/test_llmobs_eval_metric_agent_writer.py

@@ -12,6 +12,8 @@
 
 INTAKE_ENDPOINT = agent_config.trace_agent_url
 AGENT_PROXY_URL = f"{INTAKE_ENDPOINT}{EVP_PROXY_AGENT_BASE_PATH}{EVAL_ENDPOINT}"
+UNIX_AGENT_INTAKE = "unix:///var/run/datadog/apm.sock"
+UNIX_AGENT_PROXY_URL = "{}{}{}".format(UNIX_AGENT_INTAKE, EVP_PROXY_AGENT_BASE_PATH, EVAL_ENDPOINT)
 
 
 def test_writer_start(mock_writer_logs):
@@ -21,6 +23,15 @@ def test_writer_start(mock_writer_logs):
     llmobs_eval_metric_writer.stop()
 
 
+def test_unix_socket_writer_start(mock_writer_logs):
+    llmobs_eval_metric_writer = LLMObsEvalMetricWriter(1, 1, is_agentless=False, _override_url=UNIX_AGENT_INTAKE)
+    llmobs_eval_metric_writer.start()
+    mock_writer_logs.debug.assert_has_calls(
+        [mock.call("started %r to %r", "LLMObsEvalMetricWriter", UNIX_AGENT_PROXY_URL)]
+    )
+    llmobs_eval_metric_writer.stop()
+
+
 def test_buffer_limit(mock_writer_logs):
     llmobs_eval_metric_writer = LLMObsEvalMetricWriter(1, 1, is_agentless=False)
     for _ in range(1001):

tests/llmobs/test_llmobs_span_agent_writer.py

@@ -16,12 +16,22 @@
 
 INTAKE_ENDPOINT = agent_config.trace_agent_url
 AGENT_PROXY_URL = "{}{}{}".format(INTAKE_ENDPOINT, EVP_PROXY_AGENT_BASE_PATH, SPAN_ENDPOINT)
+UNIX_AGENT_INTAKE = "unix:///var/run/datadog/apm.sock"
+UNIX_AGENT_PROXY_URL = "{}{}{}".format(UNIX_AGENT_INTAKE, EVP_PROXY_AGENT_BASE_PATH, SPAN_ENDPOINT)
 
 
 def test_writer_start(mock_writer_logs):
     llmobs_span_writer = LLMObsSpanWriter(1, 1, is_agentless=False)
     llmobs_span_writer.start()
     mock_writer_logs.debug.assert_has_calls([mock.call("started %r to %r", "LLMObsSpanWriter", AGENT_PROXY_URL)])
+    llmobs_span_writer.stop()
+
+
+def test_unix_socket_writer_start(mock_writer_logs):
+    llmobs_span_writer = LLMObsSpanWriter(1, 1, is_agentless=False, _override_url=UNIX_AGENT_INTAKE)
+    llmobs_span_writer.start()
+    mock_writer_logs.debug.assert_has_calls([mock.call("started %r to %r", "LLMObsSpanWriter", UNIX_AGENT_PROXY_URL)])
+    llmobs_span_writer.stop()
 
 
 def test_buffer_limit(mock_writer_logs):