Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Inconsistency with documentation for default value of DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED #11905

Open
frrahat opened this issue Jan 13, 2025 · 0 comments
Labels

Comments

@frrahat
Copy link

frrahat commented Jan 13, 2025

Tracer Version(s)

2.x

Python Version(s)

Python 3.x

Pip Version(s)

pip 22.x

Bug Report

As per documentation default value for DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED is False:

DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED:
type: Boolean
default: False

But in code it is being passed as True:

self._128_bit_trace_id_enabled = _get_config("DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED", True, asbool)

I think it was introduced by this: #7181 and True as default is the expected here. So need to update the documentation accordingly.

Reproduction Code

No response

Error Logs

No response

Libraries in Use

No response

Operating System

No response

@frrahat frrahat added the bug label Jan 13, 2025
frrahat added a commit to frrahat/dd-trace-py that referenced this issue Jan 13, 2025
frrahat added a commit to frrahat/dd-trace-py that referenced this issue Jan 13, 2025
frrahat added a commit to frrahat/dd-trace-py that referenced this issue Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant